From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Josh Steadmon <steadmon@google.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v3 0/3] send-email: add --mailmap support
Date: Tue, 27 Aug 2024 18:55:04 -0700 [thread overview]
Message-ID: <xmqqjzg15s3r.fsf@gitster.g> (raw)
In-Reply-To: <20240827-jk-send-email-mailmap-support-v3-0-bec5ba9be391@gmail.com> (Jacob Keller's message of "Tue, 27 Aug 2024 14:27:15 -0700")
Jacob Keller <jacob.e.keller@intel.com> writes:
> Changes in v3:
> - Edit description of patch 1 to clarify lack of validation of email
> addresses.
> - Update tests for check-mailmap, removing the bogus contact tests entirely.
> - Link to v2: https://lore.kernel.org/r/20240819-jk-send-email-mailmap-support-v2-0-d212c3f9e505@gmail.com
All the incremental changes looked sensible to me. Let me wait for
a few days and then mark the topic for 'next', unless others find
issues.
Thanks.
next prev parent reply other threads:[~2024-08-28 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 21:27 [PATCH v3 0/3] send-email: add --mailmap support Jacob Keller
2024-08-27 21:27 ` [PATCH v3 1/3] check-mailmap: accept "user@host" contacts Jacob Keller
2024-08-27 21:27 ` [PATCH v3 2/3] check-mailmap: add options for additional mailmap sources Jacob Keller
2024-08-27 21:27 ` [PATCH v3 3/3] send-email: add mailmap support via sendemail.mailmap and --mailmap Jacob Keller
2024-08-28 1:55 ` Junio C Hamano [this message]
2024-08-28 21:23 ` [PATCH v3 0/3] send-email: add --mailmap support Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzg15s3r.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).