From: Junio C Hamano <gitster@pobox.com>
To: Aaron Plattner <aplattner@nvidia.com>
Cc: <git@vger.kernel.org>, Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] credential: clear expired c->credential, unify secret clearing
Date: Thu, 06 Jun 2024 11:44:53 -0700 [thread overview]
Message-ID: <xmqqjzj1lxlm.fsf@gitster.g> (raw)
In-Reply-To: <20240606183516.4077896-2-aplattner@nvidia.com> (Aaron Plattner's message of "Thu, 6 Jun 2024 11:35:16 -0700")
Aaron Plattner <aplattner@nvidia.com> writes:
> v3: I reverted the behavior change to credential_reject() and just unified
> everything to use credential_clear_secrets() instead. We can rework
> credential_reject() in a later change if we decide to. So the only behavior
> change now should be the expiration case in credential_fill()
Looks good.
>
> I also updated some of the comments in credential.h to mention the new struct
> fields.
Thanks for paying attention to such details. I very much like these
updated comments.
Will queue.
next prev parent reply other threads:[~2024-06-06 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 18:35 [PATCH v3] credential: clear expired c->credential, unify secret clearing Aaron Plattner
2024-06-06 18:44 ` Junio C Hamano [this message]
2024-06-08 11:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzj1lxlm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aplattner@nvidia.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).