From: Junio C Hamano <gitster@pobox.com>
To: Kang-Che Sung <explorer09@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Combined diff format: Show all filenames by default?
Date: Fri, 03 May 2024 12:42:57 -0700 [thread overview]
Message-ID: <xmqqjzka65ry.fsf@gitster.g> (raw)
In-Reply-To: <CADDzAfPbSv00AfzdJ5DZbXM8YjAr=po6Y_1Y0weyw5dvVA6qFg@mail.gmail.com> (Kang-Che Sung's message of "Sat, 4 May 2024 03:11:06 +0800")
Kang-Che Sung <explorer09@gmail.com> writes:
>> As the format HAS ALREADY lasted for a long time since its
>> introduction in d8f4790e (diff-tree --cc: denser combined diff
>> output for a merge commit., 2006-01-24), it is too late to change
>> the default.
>
> I wonder what things would break if we change the default behavior of this?
Human users who rarely if ever rename files will start complaining
for wasted vertical screen real estates taken by the extra lines.
Nothing is broken, and you are proposing to break things. Be more
gentle to existing users; "what would break if we change?" is an
absolutely wrong attitude to approach this.
> Well, I won't expect the default to be changed for uses in scripts or
> GUI frontends. I wish to change the default for interactive, terminal
> uses, so that usability comes in "out of the box".
How would a script that is running by interactive users whose
standard input and output streams are connected to a terminal adjust
to sudden change of the default? The "git" invocation in such an
environment would not be able to tell if you typed it or if you
typed the name of the script.
next prev parent reply other threads:[~2024-05-03 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 2:06 Combined diff format: Show all filenames by default? Kang-Che Sung
2024-05-03 14:57 ` Junio C Hamano
2024-05-03 19:11 ` Kang-Che Sung
2024-05-03 19:42 ` Junio C Hamano [this message]
2024-05-03 22:25 ` Kang-Che Sung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzka65ry.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=explorer09@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).