From: Junio C Hamano <gitster@pobox.com>
To: Javier Mora <cousteaulecommandant@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Eric Sunshine <sunshine@sunshineco.com>,
cousteau via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] doc/git-bisect: clarify `git bisect run` syntax
Date: Mon, 23 Oct 2023 10:46:54 -0700 [thread overview]
Message-ID: <xmqqjzrdnsdt.fsf@gitster.g> (raw)
In-Reply-To: <CAH1-q0hrfROfQROXGoCfde4MFkEjxjSMneDcqLO1pqYpe+bN9g@mail.gmail.com> (Javier Mora's message of "Mon, 23 Oct 2023 17:27:17 +0100")
Javier Mora <cousteaulecommandant@gmail.com> writes:
>> The output of `git bisect -h` suffers the same problem. Perhaps this
>> patch can fix that, as well?
>
> Certainly possible. Probably best if I put that on a second patch
> though (i.e. a separate commit). Or should I just squash everything
> together?
In this case, a single patch is the way to go; otherwise we will
(tentatively) be in an inconsistent state after applying one until
the other gets applied.
> There are still multiple .po files containing the old string, I guess
> I don't need to touch those?
Correct.
> Speaking of which, looking at the .po files I've found that there's
> also a `git bisect--helper` command; I don't know if that's relevant
> nor how to modify that.
bisect--helper has been retired but most of the messages used by it
should have been in use by bisect proper, so only the "this message
appears here" comments may be wrong.
In any case, touching po/ is not in the scope of this isolated fix.
The i18n group has their own workflows to update the files there,
and those touching the code and docs should not have to touch them
in general.
>> I wonder if we should eventually move these into the
>> proper SYNOPSIS section.
>
> Seems reasonable. I was actually wondering about that.
But not as a part of this isolated fix.
next prev parent reply other threads:[~2023-10-23 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 20:02 [PATCH] doc/git-bisect: clarify `git bisect run` syntax cousteau via GitGitGadget
2023-10-22 21:32 ` Eric Sunshine
2023-10-23 0:35 ` Junio C Hamano
2023-10-23 7:38 ` Patrick Steinhardt
2023-10-23 16:27 ` Javier Mora
2023-10-23 17:46 ` Junio C Hamano [this message]
2023-10-23 17:23 ` Junio C Hamano
2023-10-23 19:23 ` [PATCH v2] " cousteau via GitGitGadget
2023-10-23 19:36 ` Eric Sunshine
2023-10-23 22:53 ` Javier Mora
2023-10-23 23:18 ` Eric Sunshine
2023-10-24 0:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzrdnsdt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=cousteaulecommandant@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).