From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1D426C46CA1
	for <git@archiver.kernel.org>; Mon, 18 Sep 2023 16:06:07 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229966AbjIRQGK (ORCPT <rfc822;git@archiver.kernel.org>);
        Mon, 18 Sep 2023 12:06:10 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39246 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229959AbjIRQGE (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 18 Sep 2023 12:06:04 -0400
Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D446849F0
        for <git@vger.kernel.org>; Mon, 18 Sep 2023 09:05:11 -0700 (PDT)
Received: from pb-smtp1.pobox.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 4F88D1BD90A;
        Mon, 18 Sep 2023 12:04:53 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:in-reply-to:references:date:message-id:mime-version
        :content-type; s=sasl; bh=5tIhyS4ToSEZOx9B/tkF+Gm7j9INRuZgexBSh3
        5C2Do=; b=AI4ixnUjsFP0QmhLeftUaMXrBvwsajY4zEcmcJpuNAiKy5QSQrNjYu
        tD8vWlhYCdiv1aZp6EjzJE+Ui30CF6qIodHtfQEwe4JZALDCPFElYkwrN8IgfJO3
        QS9Ud5rSjCT2qqt79Pd7EPVrw0Xxb8qxLBn50peEmwmd8Sd0TeN8Y=
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 477AA1BD909;
        Mon, 18 Sep 2023 12:04:53 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.125.153.120])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp1.pobox.com (Postfix) with ESMTPSA id AA7F31BD908;
        Mon, 18 Sep 2023 12:04:52 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc:     Mark Levedahl <mlevedahl@gmail.com>, me@yadavpratyush.com,
        git@vger.kernel.org
Subject: Re: [PATCH v2] git-gui - re-enable use of hook scripts
In-Reply-To: <260b62dc-d45b-58fa-85c4-ffbd981a1c84@gmx.de> (Johannes
        Schindelin's message of "Mon, 18 Sep 2023 17:26:21 +0200 (CEST)")
References: <xmqqy1h6auy7.fsf@gitster.g>
        <20230916210131.78593-1-mlevedahl@gmail.com>
        <260b62dc-d45b-58fa-85c4-ffbd981a1c84@gmx.de>
Date:   Mon, 18 Sep 2023 09:04:51 -0700
Message-ID: <xmqqjzsnmpr0.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 1A2BF474-563D-11EE-BD32-78DCEB2EC81B-77302942!pb-smtp1.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Sounds good. FWIW I ran a couple experiments here, too:
>
> 	% file pathtype "C:/foo"
> 	absolute
> 	% file pathtype ".git/hooks"
> 	relative
> 	% file pathtype ".git\\hooks"
> 	relative
> 	% file pathtype "/foo"
> 	volumerelative
> 	% file pathtype "foo"
> 	relative
>
> The problem, therefore, is that `file pathtype` does not discern between a
> bare file name and a relative path. The proposed patch looks correct to
> me.
>
> Thank you,
> Johannes

Yup, the other "run hooks in a more modern way using 'git hook'"
patch is the right solution for the immediate breakage, but it still
cannot remove this sanitize_command_line proc as we have other users
and use cases where we want to use the sanitized $PATH search, so
this fix is still needed.

Thanks for a quick review on both patches.