From: Junio C Hamano <gitster@pobox.com>
To: 韩仰 <hanyang.tony@bytedance.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"jacob.keller@gmail.com" <jacob.keller@gmail.com>
Subject: Re: [PATCH] blame: allow --contents to work with bare repo
Date: Wed, 19 Jul 2023 14:21:18 -0700 [thread overview]
Message-ID: <xmqqjzuva981.fsf@gitster.g> (raw)
In-Reply-To: <CAG1j3zFps5yKwu=DEgkfmZDrzVoRkdeRFMFbq16ZmyOaTXxWeQ@mail.gmail.com> ("韩仰"'s message of "Wed, 19 Jul 2023 03:48:34 -0700")
韩仰 <hanyang.tony@bytedance.com> writes:
> - setup_work_tree();
> + if (!sb->contents_from) {
> + setup_work_tree();
> + }
Unwanted {braces} around a single statement.
The patch is severely whitespace damaged and does not apply.
Please check your outgoing mail route and make sure it does not
happen when you send out an updated patch. Sending an e-mail to
yourself and checking what you received may also work as a way to
sanity-check without bombarding other people and the list with a
test message.
Thanks.
next prev parent reply other threads:[~2023-07-19 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 10:48 [PATCH] blame: allow --contents to work with bare repo 韩仰
2023-07-19 21:21 ` Junio C Hamano [this message]
2023-07-21 3:57 ` [PATCH v2] " Han Young
2023-07-21 14:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzuva981.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanyang.tony@bytedance.com \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).