From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Matěj Cepl" <mcepl@cepl.eu>, git@vger.kernel.org
Subject: Re: git-send-email with GPG signed commits?
Date: Thu, 20 Oct 2022 11:03:52 -0700 [thread overview]
Message-ID: <xmqqk04us77b.fsf@gitster.g> (raw)
In-Reply-To: <xmqqr0z2s7w4.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 20 Oct 2022 10:48:59 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> I think you would need some kind of "author-sig" header that signs the
>> commit object bytes _without_ the commit header at all. And that assumes
>> the maintainer's workflow is to never modify a patch in transit, and to
>> apply it at the exact same spot that you wrote it (so that the parent
>> and tree ids remain the same).
>
> Doesn't it immediately break down once you send a 2-patch series?
Ah, if you did not mean "without the committer header", but "without
any of the header fields of the commit object", then it would
probably work. But then that loses the context to apply the patch
completely, so I can apply a patch you author-signed to a place
where it wouldn't work and end up with a broken commit.
Start from the original commit object, remove the committer, the
author, the tree, and the parent headers, add a parent-tree header
that records the tree object of the first parent, and call that a
"modified commit object". Then compute the signature over it and
the patch text. The e-mailed patch now needs to carry the value of
the parent-tree header and the signature.
At the receiving end, the reverse operation can be done and the
resulting commit may have two new headers (author-sig and
parent-tree). In the resulting commit, parent-tree does not have to
match the tree of its first parent, if the integrator chose to apply
it on a different commit, and as long as the patch text matches,
things should verify.
So, some kind of "author-sig" is certainly possible, but is it
practically useful? I am not sure. It still does not even allow
typofixes on the receiving end.
next prev parent reply other threads:[~2022-10-20 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 4:26 git-send-email with GPG signed commits? Matěj Cepl
2022-10-20 12:46 ` Konstantin Ryabitsev
2022-10-20 17:29 ` Matěj Cepl
2022-10-20 18:55 ` Konstantin Ryabitsev
2022-10-20 17:44 ` Jeff King
2022-10-20 17:48 ` Junio C Hamano
2022-10-20 18:03 ` Junio C Hamano [this message]
2022-10-20 18:31 ` Jeff King
2022-10-20 19:01 ` Konstantin Ryabitsev
2022-10-20 19:40 ` rsbecker
2022-10-20 21:03 ` Matěj Cepl
2022-10-20 21:22 ` brian m. carlson
2022-10-21 0:12 ` Matěj Cepl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk04us77b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mcepl@cepl.eu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox