From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Philip Oakley <philipoakley@iee.email>,
Guy Maurel <guy.j@maurel.de>,
git@vger.kernel.org
Subject: Re: a problem with git describe
Date: Tue, 26 Apr 2022 08:36:59 -0700 [thread overview]
Message-ID: <xmqqk0bbsvok.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2204261726460.355@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Tue, 26 Apr 2022 17:30:12 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Sat, 23 Apr 2022, Junio C Hamano wrote:
>
>> Philip Oakley <philipoakley@iee.email> writes:
>>
>> >> guy@renard ~/Software/uncrustify $ sudo git describe --always --dirty
>> > ...
>> > There has also been added an escape hatch of allowing "*" for the
>> > permitted safe directories. but do check the updated manuals, and the
>> > git mailing list archive (update the search in the above link).
>>
>> In this particular case, I do not think '*' is needed, but you need
>> to be careful here. Whose configuration are you suggesting to add
>> such an entry? Yourself? ~root/.gitconfig?
>
> One relatively simple work-around might be to call `sudo chown root .`
> before running `sudo make install`, but of course this would require the
> `rm -rf` to be run via `sudo`, too.
chown root may make it owned by nobody4, though ;-)
> Do we want to make use of the environment variable `SUDO_UID` that is set
> by `sudo`?
"run this command under 'sudo'" would be a social engineering attack
we do not want to defend against, so I am OK with that, but then
allowing
sudo "GIT_SAFE_DIRECTORIES=. make install"
does not look too bad, either.
prev parent reply other threads:[~2022-04-26 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 9:12 a problem with git describe Guy Maurel
2022-04-23 11:27 ` Philip Oakley
2022-04-23 16:09 ` Junio C Hamano
2022-04-23 23:44 ` Junio C Hamano
2022-04-25 2:01 ` Carlo Marcelo Arenas Belón
2022-04-25 5:05 ` SZEDER Gábor
2022-04-25 6:03 ` Carlo Marcelo Arenas Belón
2022-04-25 6:39 ` Junio C Hamano
2022-04-25 7:02 ` Carlo Marcelo Arenas Belón
2022-04-25 8:40 ` Carlo Marcelo Arenas Belón
2022-04-25 15:11 ` Guy Maurel
2022-04-26 15:43 ` Johannes Schindelin
2022-04-26 15:56 ` rsbecker
2022-04-26 16:35 ` Carlo Arenas
2022-04-26 16:46 ` Junio C Hamano
2022-04-26 17:15 ` Carlo Arenas
2022-04-26 15:45 ` Johannes Schindelin
2022-04-26 16:25 ` Junio C Hamano
2022-04-26 1:52 ` Taylor Blau
2022-04-26 15:41 ` Johannes Schindelin
2022-04-26 15:50 ` Taylor Blau
2022-04-26 15:30 ` Johannes Schindelin
2022-04-26 15:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0bbsvok.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=guy.j@maurel.de \
--cc=philipoakley@iee.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).