From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>,
Stefan Beller <stefanbeller@gmail.com>,
"Dr . Matthias St . Pierre" <m.st.pierre@ncp-e.com>
Subject: Re: [PATCH v3 2/2] blame: document --color-* options
Date: Mon, 04 Oct 2021 04:41:00 -0700 [thread overview]
Message-ID: <xmqqk0itxbjn.fsf@gitster.g> (raw)
In-Reply-To: e70942cd-8362-b8d0-f168-01f6c190fb0b@gmail.com
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> On 02/10/21 02.10, Eric Sunshine wrote:
>>> + config option. Only the line annotation (see "The Default Format" section)
>>> + is colored.
>> You can drop the last sentence entirely if you start the blurb like
>> this:
>> Color line annotations differently, if...
>>
>>> +--color-by-age::
>>> + Color lines depending on the age of the line. The `color.blame.highlightRecent`
>>> + config option controls what color is used for which range of age. Only the
>>> + line annotation (see "The Default Format" section) is colored.
>> Ditto about dropping the last sentence.
>> Color line annotations depending upon the age of the line.
>>
>
> I observed that both --color-lines and --color-by-age only apply to
> default blame format, ...
Technically, it is sufficient to say "color line annotations"
because the default format is the only one that is described to give
"line annotations". I do not think it would hurt too much to be a
bit more explicit, perhaps like:
Color line annotations, depending upon the age of the line, in
the default output format.
I personally feel "(see section X)" is being a bit more ditracting
than being helpful to readers.
Thanks.
prev parent reply other threads:[~2021-10-04 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 11:37 [PATCH v3 0/2] blame: documentation update Bagas Sanjaya
2021-10-01 11:37 ` [PATCH v3 1/2] blame: Describe default output format Bagas Sanjaya
2021-10-01 22:43 ` Junio C Hamano
2021-10-01 11:37 ` [PATCH v3 2/2] blame: document --color-* options Bagas Sanjaya
2021-10-01 19:10 ` Eric Sunshine
2021-10-02 2:35 ` Bagas Sanjaya
2021-10-04 11:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0itxbjn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=m.st.pierre@ncp-e.com \
--cc=stefanbeller@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).