From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: "Git List" <git@vger.kernel.org>,
"Ulrich Windl" <Ulrich.Windl@rz.uni-regensburg.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Han-Wen Nienhuys" <hanwen@google.com>
Subject: Re: [PATCH v2] branch: allow deleting dangling branches with --force
Date: Thu, 26 Aug 2021 12:05:20 -0700 [thread overview]
Message-ID: <xmqqk0k8do27.fsf@gitster.g> (raw)
In-Reply-To: <325d64e9-8a31-6ba0-73f2-5e9d67b8682f@web.de> ("René Scharfe"'s message of "Thu, 26 Aug 2021 20:19:15 +0200")
René Scharfe <l.s.r@web.de> writes:
> + hash=$(git rev-parse HEAD) &&
> + objpath=$(echo $hash | sed -e "s|^..|.git/objects/&/|") &&
> + git branch --no-track dangling &&
> + test_when_finished "test -f $objpath.x && mv $objpath.x $objpath" &&
Do we need test -f here?
> + mv $objpath $objpath.x &&
> + git branch --delete --force dangling &&
> + test -z "$(git for-each-ref refs/heads/dangling)"
It is not wrong per-se, but maybe
git show-ref --quiet refs/heads/dangling
is more straight-forward.
Thanks.
next prev parent reply other threads:[~2021-08-26 19:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 20:43 [PATCH RESEND] branch: allow deleting dangling branches with --force René Scharfe
2021-08-25 21:37 ` Junio C Hamano
2021-08-25 23:28 ` Ævar Arnfjörð Bjarmason
2021-08-26 18:19 ` René Scharfe
2021-08-26 7:26 ` Han-Wen Nienhuys
2021-08-26 16:54 ` Junio C Hamano
2021-08-26 17:38 ` Junio C Hamano
2021-08-27 7:24 ` Antw: [EXT] Re: [PATCH RESEND] branch: allow deleting dangling branches with ‑‑force Ulrich Windl
2021-08-27 7:53 ` Ævar Arnfjörð Bjarmason
2021-08-26 18:18 ` [PATCH RESEND] branch: allow deleting dangling branches with --force René Scharfe
2021-08-25 23:30 ` Ævar Arnfjörð Bjarmason
2021-08-26 18:19 ` René Scharfe
2021-08-26 18:19 ` [PATCH v2] " René Scharfe
2021-08-26 19:05 ` Junio C Hamano [this message]
2021-08-26 21:01 ` René Scharfe
2021-08-26 19:12 ` Ævar Arnfjörð Bjarmason
2021-08-27 18:35 ` [PATCH v3] " René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0k8do27.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Ulrich.Windl@rz.uni-regensburg.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).