From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH v2] multi-pack-index: fix *.rev cleanups with --object-dir
Date: Mon, 23 Aug 2021 10:58:09 -0700 [thread overview]
Message-ID: <xmqqk0kcqc0e.fsf@gitster.g> (raw)
In-Reply-To: <YSPWQtOjKVgIKqsd@nand.local> (Taylor Blau's message of "Mon, 23 Aug 2021 13:09:22 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Mon, Aug 23, 2021 at 07:05:31PM +0200, Johannes Berg wrote:
>> On Mon, 2021-08-23 at 12:06 -0400, Jeff King wrote:
>> > I'm not entirely convinced that writing a midx when not "inside" a repo
>> > is something that we want to support. But if we do, then...
>>
>> Seemed like that was the point of --object-dir?
>
> Stolee (cc'd) would know more as the original author, but as I recall
> the point of `--object-dir` was to be able to write a midx in
> directories which were acting as Git repositories, but didn't contain a
> `.git` directory.
>
> It's kind of a strange use-case, but I recall that it was important at
> the time. Maybe he could shed more light on why. (Either way, we're
> stuck with it ;)).
It does sound strange. "git -C $there multi-pack-index write"
would have felt more natural.
next prev parent reply other threads:[~2021-08-23 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 9:40 [PATCH v2] multi-pack-index: fix *.rev cleanups with --object-dir Johannes Berg
2021-08-23 16:06 ` Jeff King
2021-08-23 17:05 ` Johannes Berg
2021-08-23 17:09 ` Taylor Blau
2021-08-23 17:56 ` Jeff King
2021-08-23 17:58 ` Junio C Hamano [this message]
2021-08-23 18:00 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0kcqc0e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).