From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Jacob Vosmaer <jacob@gitlab.com>
Subject: Re: [PATCH] refs: switch peel_ref() to peel_iterated_oid()
Date: Fri, 22 Jan 2021 13:38:23 -0800 [thread overview]
Message-ID: <xmqqk0s47iuo.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <YAiOPzOT52v+dOgL@nand.local> (Taylor Blau's message of "Wed, 20 Jan 2021 15:10:39 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> On Wed, Jan 20, 2021 at 02:44:43PM -0500, Jeff King wrote:
>> This has been bugging me for years, and came up again in:
>>
>> https://lore.kernel.org/git/YAhXw9Gvn5Pyvacq@coredump.intra.peff.net/
>>
>> so I decided to finally do something about it. There's a minor textual
>> conflict with the caller being touched in that thread, but it's easy to
>> resolve. So I think it's OK to consider the two independent.
>>
>> The commit message turned out rather long. I hope that doesn't scare
>> anybody away, but I wanted to cover all of the bases.
>
> Thanks for all of the detail. Suffice it to say, I was not scared away,
> and am in fact quite comfortable with this direction.
>
> Sorry for sending such a short response to such a long email, but I
> agree with the discussion in the patch message, and I don't have
> anything to add other than my approval and a:
>
> Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
> Thanks,
> Taylor
Thanks, both.
prev parent reply other threads:[~2021-01-22 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 19:44 [PATCH] refs: switch peel_ref() to peel_iterated_oid() Jeff King
2021-01-20 20:10 ` Taylor Blau
2021-01-22 21:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0s47iuo.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob@gitlab.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).