git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: git format-patch --range-diff bug?
Date: Thu, 12 Nov 2020 09:57:46 -0800	[thread overview]
Message-ID: <xmqqk0uqjw4l.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201112174353.GD4270@szeder.dev> ("SZEDER Gábor"'s message of "Thu, 12 Nov 2020 18:43:53 +0100")

SZEDER Gábor <szeder.dev@gmail.com> writes:

> 	: The output of the range-diff command is what I would expect to be included in the generated patch &&
> 	git range-diff v1...v2 &&
>
> 	: But that is not what we get embedded in the generated patch &&
> 	git format-patch -1 --range-diff=v1...v2 v2 &&

The other day I did something similar and ended up with

	git format-patch --range-diff=v1 v1..v2

Would it help not to use the three-dot form?  From my reading of
"git format-patch --range-diff=<previous>" description, it only
needs to give a single range (i.e. previous side of series of
commits) as the other range to be compared are by definition the
patches you are producing, while v1...v2 syntax is to give two
ranges with one option.  So...

  reply	other threads:[~2020-11-12 17:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 17:43 git format-patch --range-diff bug? SZEDER Gábor
2020-11-12 17:57 ` Junio C Hamano [this message]
2020-11-12 18:32   ` Eric Sunshine
2020-11-12 18:59     ` Junio C Hamano
2020-11-12 20:06       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk0uqjw4l.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).