From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git <git@vger.kernel.org>,
Christian Couder <chriscool@tuxfamily.org>,
Miriam Rubio <mirucam@gmail.com>
Subject: Re: [PATCH v2] bisect: don't use invalid oid as rev when starting
Date: Thu, 24 Sep 2020 09:44:26 -0700 [thread overview]
Message-ID: <xmqqk0wjgm51.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAP8UFD3HtiAj2yiHBZOeqm-=VxVeV7mpwvFRV_mV8y-vsxgQUQ@mail.gmail.com> (Christian Couder's message of "Thu, 24 Sep 2020 13:08:01 +0200")
Christian Couder <christian.couder@gmail.com> writes:
>> > +test_expect_success 'bisect start without -- uses unknown arg as path restriction' '
>>
>> To avoid the overly long line (and also to re-use existing naming
>> conventions), I replaced "path restrictions" by "pathspecs" here. What do
>> you think?
>
> It's not a huge issue, but I tend to prefer using "restrictions"
> because the tests that check that these arguments are used properly
> are called "restricting bisection on one dir" and "restricting
> bisection on one dir and a file". So I feel that it keeps test names
> more coherent.
Hmph, but in the context of a sentence "use an arg as X", we should
try to pick a well-known word to describe various Git arguments for
X, no? The one you are using, in order to filter the set of commits
involved in the operation to those that touch specific set of paths,
already has its own established name and the word is "pathspec".
So...?
next prev parent reply other threads:[~2020-09-24 16:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 17:09 [PATCH] bisect: don't use invalid oid as rev when starting Christian Couder
2020-09-23 17:27 ` Junio C Hamano
2020-09-23 20:37 ` Johannes Schindelin
2020-09-23 21:05 ` Johannes Schindelin
2020-09-23 21:39 ` Junio C Hamano
2020-09-24 6:10 ` Christian Couder
2020-09-24 6:48 ` Junio C Hamano
2020-09-24 7:51 ` Johannes Schindelin
2020-09-24 16:39 ` Junio C Hamano
2020-09-24 18:38 ` Junio C Hamano
2020-09-25 7:13 ` Johannes Schindelin
2020-09-25 7:14 ` Johannes Schindelin
2020-09-25 16:54 ` Junio C Hamano
2020-09-24 6:03 ` [PATCH v2] " Christian Couder
2020-09-24 7:49 ` Johannes Schindelin
2020-09-24 11:08 ` Christian Couder
2020-09-24 16:44 ` Junio C Hamano [this message]
2020-09-24 18:55 ` Junio C Hamano
2020-09-24 19:25 ` Junio C Hamano
2020-09-24 19:56 ` Junio C Hamano
2020-09-24 20:53 ` Junio C Hamano
2020-09-25 13:09 ` Christian Couder
2020-09-25 13:01 ` [PATCH v3] " Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0wjgm51.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=mirucam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox