From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, dstolee@microsoft.com, szeder.dev@gmail.com,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v3 3/3] git-prompt: include sparsity state as well
Date: Mon, 22 Jun 2020 09:35:34 -0700 [thread overview]
Message-ID: <xmqqk0zzdpnt.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <d99202f8e1443f517b16811b7d2ba2593898e9d0.1592716887.git.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Sun, 21 Jun 2020 05:21:27 +0000")
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Elijah Newren <newren@gmail.com>
> ...
> The reason for showing the "|SPARSE" substring before other states is to
> ...
> The fact that sparsity isn't just cached metadata or additional
> information is what leads us to show it more similarly to the
> in-progress states, but the fact that sparsity is not transient like the
> in-progress states might cause some users to want an abbreviated
> notification of sparsity state or perhaps even be able to turn it off.
> Allow GIT_PS1_COMPRESSSPARSESTATE to be set to request that it be
> shortened to a single character ('?'), and GIT_PS1_OMITSPARSESTATE to be
> set to request that sparsity state be omitted from the prompt entirely.
Nicely explained. It somewhat feels a bit overkill to have two
(i.e. compress vs omit) knobs---the other "semi-permanent" state
that may be of interest but could become too noisy only have one
knob that toggles between showing a short-and-non-intrusive sign
and not showing anything at all with GIT_PS1_SHOWSTASHSTATE, and
that smells like a better balance to me, but I dunno.
Thanks. Will queue.
prev parent reply other threads:[~2020-06-22 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 23:33 [PATCH 0/2] Sparse checkout status Elijah Newren via GitGitGadget
2020-06-16 23:33 ` [PATCH 1/2] [RFC] wt-status: show sparse checkout status as well Elijah Newren via GitGitGadget
2020-06-17 14:50 ` Derrick Stolee
2020-06-17 15:46 ` Elijah Newren
2020-06-16 23:33 ` [PATCH 2/2] [RFC] git-prompt: include sparsity state " Elijah Newren via GitGitGadget
2020-06-18 20:49 ` [PATCH v2 0/2] Sparse checkout status Elijah Newren via GitGitGadget
2020-06-18 20:49 ` [PATCH v2 1/2] wt-status: show sparse checkout status as well Elijah Newren via GitGitGadget
2020-06-18 20:49 ` [PATCH v2 2/2] git-prompt: include sparsity state " Elijah Newren via GitGitGadget
2020-06-19 16:15 ` SZEDER Gábor
2020-06-19 16:33 ` Junio C Hamano
2020-06-19 16:35 ` Junio C Hamano
2020-06-18 21:45 ` [PATCH v2 0/2] Sparse checkout status Junio C Hamano
2020-06-18 23:18 ` Elijah Newren
2020-06-21 1:34 ` Elijah Newren
2020-06-21 5:21 ` [PATCH v3 0/3] " Elijah Newren via GitGitGadget
2020-06-21 5:21 ` [PATCH v3 1/3] wt-status: show sparse checkout status as well Elijah Newren via GitGitGadget
2020-06-21 5:21 ` [PATCH v3 2/3] git-prompt: document how in-progress operations affect the prompt Elijah Newren via GitGitGadget
2020-06-21 5:21 ` [PATCH v3 3/3] git-prompt: include sparsity state as well Elijah Newren via GitGitGadget
2020-06-22 16:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0zzdpnt.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).