From: Junio C Hamano <gitster@pobox.com>
To: robbat2@gentoo.org
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: include contrib docs in dist-doc tarballs
Date: Mon, 24 Jun 2019 11:47:26 -0700 [thread overview]
Message-ID: <xmqqk1dahlc1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190623215046.24030-1-robbat2@gentoo.org> (robbat2@gentoo.org's message of "Sun, 23 Jun 2019 14:50:46 -0700")
robbat2@gentoo.org writes:
> +.PHONY: dist-doc distclean contrib-doc
I do not think I want to do this.
Contrib are not part of the core because they are not. We do not
install their "executable" from the top-level Makefile and I prefer
to keep it that way. Why should we ship their documentation
ourselves? If somebody wants to build and distribute the contrib
material, they should be spending their cycles to also build and
distribute the matching docs, not me.
> +# subdirs with install-html & install-man targets
> +contrib_doc_dirs := contrib/contacts contrib/subtree
> +doc_dirs := Documentation $(contrib_doc_dirs)
> +
> +contrib-doc:
> + $(MAKE) -C contrib/svn-fe svn-fe.html svn-fe.1 # no doc target
> + for d in $(contrib_doc_dirs) ; do \
> + $(MAKE) -C $$d doc ; \
> + done
> +
> +dist-doc: doc contrib-doc
> $(RM) -r .doc-tmp-dir
> mkdir .doc-tmp-dir
> - $(MAKE) -C Documentation WEBDOC_DEST=../.doc-tmp-dir install-webdoc
> + for d in $(doc_dirs) ; do \
> + $(MAKE) -C $$d \
> + DESTDIR=$(PWD)/ \
> + htmldir=/.doc-tmp-dir/ \
> + install-html ; \
> + done
> + : # These files have no install targets
> + cp --target .doc-tmp-dir \
"cp --target"??? It may be tempting but I do not think we can rely
on it being available everywhere.
> + contrib/subtree/git-subtree.txt \
> + contrib/contacts/git-contacts.txt \
> + contrib/svn-fe/svn-fe.html \
> + contrib/svn-fe/svn-fe.txt
prev parent reply other threads:[~2019-06-24 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 21:50 [PATCH] Makefile: include contrib docs in dist-doc tarballs robbat2
2019-06-24 18:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1dahlc1.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).