From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] Add an EditorConfig file
Date: Thu, 20 Sep 2018 07:08:35 -0700 [thread overview]
Message-ID: <xmqqk1ng2rdo.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180920000013.GZ432229@genre.crustytoothpaste.net> (brian m. carlson's message of "Thu, 20 Sep 2018 00:00:14 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> I think "make style" and the EditorConfig file are complementary. "make
> style" autoformats code into a diff. I agree that if we always used
> clang-format to format code, then this would be a non-issue in the
> EditorConfig file, since we'd just tell people to format their code and
> be done with it. However, we don't automatically do that, so I think
> this still has value.
Oh, we agree on that 100%. These are complementary.
My comment was that it would be confusing if they gave contradicting
suggestions to the end user. After letting EditorConfig to enforce
one style while typing and saving, if "make style" suggests to
format it differently, it would not be a great user experience.
The ideal response would have been "Oh, of course EditorConfig folks
already thought about that, which is a natural thing to wish for,
and they have a tool to generate clang-format configuration from the
section for C language in any EditorConfig file---here is a link.
After all, tools like clang-format look like just another editor to
them ;-)".
But that is a response in a dream-world. If there is no such tool,
I am perfectly OK if the plan is to manually keep them (loosely) in
sync. I do not think it is good use of our time to try to come up
with such a tool (unless somebody is really interested in doing it,
that is).
Thanks.
next prev parent reply other threads:[~2018-09-20 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 23:03 [PATCH] Add an EditorConfig file brian m. carlson
2018-09-17 23:18 ` Taylor Blau
2018-09-20 0:05 ` brian m. carlson
2018-09-19 3:00 ` Junio C Hamano
2018-09-20 0:00 ` brian m. carlson
2018-09-20 14:08 ` Junio C Hamano [this message]
2018-09-21 22:50 ` brian m. carlson
2018-09-24 20:05 ` Junio C Hamano
2018-09-27 22:33 ` brian m. carlson
2018-09-21 2:26 ` Eric Sunshine
2018-09-21 2:35 ` Jeff King
2018-09-21 22:19 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1ng2rdo.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).