git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Git Mailing List <git@vger.kernel.org>, max@max630.net
Subject: Re: t5562: gzip -k is not portable
Date: Tue, 19 Jun 2018 11:06:06 -0700	[thread overview]
Message-ID: <xmqqk1quvegh.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <5ee7a65d-63e1-aa6a-c3c1-663c092d0efe@web.de> ("Torsten Bögershausen"'s message of "Tue, 19 Jun 2018 19:25:15 +0200")

Torsten Bögershausen <tboegi@web.de> writes:

> Hej Max,
>
> t5562 fails here under MacOS:
> "gzip -k"  is not portable.

Sigh.  Perhaps -c would help.  Or do BSD implementations also lack -c?

 t/t5562-http-backend-content-length.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh
index 8040d80e04..98b6543827 100755
--- a/t/t5562-http-backend-content-length.sh
+++ b/t/t5562-http-backend-content-length.sh
@@ -61,9 +61,9 @@ test_expect_success 'setup' '
 '
 
 test_expect_success GZIP 'setup, compression related' '
-	gzip -k fetch_body &&
+	gzip -c fetch_body >fetch_body.gz &&
 	test_copy_bytes 10 <fetch_body.gz >fetch_body.gz.trunc &&
-	gzip -k push_body &&
+	gzip -c push_body >push_body.gz &&
 	test_copy_bytes 10 <push_body.gz >push_body.gz.trunc
 '
 

  reply	other threads:[~2018-06-19 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 17:25 t5562: gzip -k is not portable Torsten Bögershausen
2018-06-19 18:06 ` Junio C Hamano [this message]
2018-06-19 18:22   ` Eric Sunshine
2018-06-19 20:40     ` Torsten Bögershausen
2018-06-19 20:53       ` Rodrigo Campos
2018-06-19 20:53       ` Jeff King
2018-06-20  6:13         ` Torsten Bögershausen
2018-06-20 12:40           ` Jeff King
2018-06-20 15:41             ` Torsten Bögershausen
2018-06-19 20:48 ` Rodrigo Campos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk1quvegh.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=max@max630.net \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).