From: Junio C Hamano <gitster@pobox.com>
To: Lyubomyr Shaydariv <lsh.dev@ukr.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] graph.c: log.showRootMark to indicate root commits
Date: Mon, 02 Apr 2018 10:57:46 -0700 [thread overview]
Message-ID: <xmqqk1tpze1x.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <0102016283000c69-b09d1499-8a50-45a7-9f41-01be648398bc-000000@eu-west-1.amazonses.com> (Lyubomyr Shaydariv's message of "Sun, 1 Apr 2018 20:57:21 +0000")
Lyubomyr Shaydariv <lsh.dev@ukr.net> writes:
> When log.showRootMark is set, root commits are marked with
> the at sign (@).
>
> When log.showRootMark is not set, root commits are marked with
> the asterisk sign (*). This is the default behavior.
>
> Signed-off-by: Lyubomyr Shaydariv <lsh.dev@ukr.net>
> ---
So the idea is when you have a history like this:
R1--A---B
\
R2--C---D---M
to show "git log --oneline --graph D B" like
* B
* A
@ R1
* D
* C
@ R2
because you cannot tell that between R1 and D there is no
parent-child relationship otherwise?
One downside of that approach is that it is not clear how this
feature should interact with --left-right. I do not think there is
a clean way to do that, unless you come up with a pair of symbols,
not just a single '@'.
Another way to show that there is no parent-child relationship
between R1 and D is to show it like this instead:
* B
* A
\
* R1
* D
* C
* R2
and that would work well with --left-right automatically (as you
would just do the same thing as you would to a normal asterisk).
next prev parent reply other threads:[~2018-04-02 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 20:57 [PATCH] graph.c: log.showRootMark to indicate root commits Lyubomyr Shaydariv
2018-04-02 17:57 ` Junio C Hamano [this message]
2018-04-02 18:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1tpze1x.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lsh.dev@ukr.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).