Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Turner <David.Turner@twosigma.com>
Cc: "'René Scharfe'" <l.s.r@web.de>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	"peff@peff.net" <peff@peff.net>,
	"jrnieder@gmail.com" <jrnieder@gmail.com>,
	"Duy Nguyen" <pclouds@gmail.com>
Subject: Re: [PATCH v2] xgethostname: handle long hostnames
Date: Tue, 18 Apr 2017 20:49:10 -0700	[thread overview]
Message-ID: <xmqqk26hawg9.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <e1f3ca5df4484496a2e0ab601a940ecb@exmbdft7.ad.twosigma.com> (David Turner's message of "Tue, 18 Apr 2017 17:52:40 +0000")

David Turner <David.Turner@twosigma.com> writes:

> If the writer has the smaller HOST_NAME_MAX, this will work fine.  If the reader
> has the smaller HOST_NAME_MAX, and the writer's actual value is too long,
> then there's no way the strcmp would succeed anyway.  So I don't think we need
> to worry about it.

Hmph, I have to agree with that reasoning, only because the value we
read into locking_host[] is not used for error reporting at all.  I
would have insisted to read what is on the filesystem anyway if that
were not the case.

Thanks.

  reply	other threads:[~2017-04-19  3:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 16:17 [PATCH v2] xgethostname: handle long hostnames David Turner
2017-04-18  1:19 ` Junio C Hamano
2017-04-18  1:41   ` Junio C Hamano
2017-04-18 16:07     ` René Scharfe
2017-04-18 16:17       ` Jeff King
2017-04-19  1:47         ` Junio C Hamano
2017-04-18 17:52       ` David Turner
2017-04-19  3:49         ` Junio C Hamano [this message]
2017-04-19  1:49       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk26hawg9.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=David.Turner@twosigma.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=l.s.r@web.de \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox