From: Junio C Hamano <gitster@pobox.com>
To: "Grégoire PARIS" <postmaster@greg0ire.fr>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: dotfiles in git template dir are not copied
Date: Fri, 17 Feb 2017 14:56:45 -0800 [thread overview]
Message-ID: <xmqqk28opgsy.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <2bae8d8a-f0bf-fa8b-8ce4-6880d3490b43@greg0ire.fr> ("Grégoire PARIS"'s message of "Fri, 17 Feb 2017 22:42:43 +0100")
Grégoire PARIS <postmaster@greg0ire.fr> writes:
>> You could, for example, have your template directory itself be a git
> repository.
>
> I can and I do and indeed, that might be the reason behind this.
> I made a PR to document this : https://github.com/git/git/pull/325
Let's take a look.
> From: Grégoire PARIS <postmaster@greg0ire.fr>
> Date: Fri, 17 Feb 2017 22:33:40 +0100
> Subject: [PATCH] Document dotfiles exclusion on template copy
>
> Since there is no dotfile in the default template directory, there was
> no point in making the check for . or .. more accurate when copying. Now
> that you can customize the template directory, it would make sense, but
> it's actually a good thing to at this because you would not want to have
> your git directory copied in every git directory that is created should
> you decide to put your template directory under version control. Plus it
> might be used as a feature by people who would want to exclude some
> files.
OK.
> See https://public-inbox.org/git/20170217204411.2yixhuazgczxmmxa@sigill.intra.peff.net/T/#t
I do not think what was discussed there adds much. Drop this line.
Instead, add your sign-off (Documentation/SubmittingPatches) here
Signed-off-by: Grégoire PARIS <postmaster@greg0ire.fr>
> ---
> Documentation/git-init.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt
> index 9d27197de8..e3b185cf86 100644
> --- a/Documentation/git-init.txt
> +++ b/Documentation/git-init.txt
> @@ -117,7 +117,7 @@ TEMPLATE DIRECTORY
> ------------------
>
> The template directory contains files and directories that will be copied to
> -the `$GIT_DIR` after it is created.
> +the `$GIT_DIR` after it is created, unless their name starts with a dot.
"... that will be copied ..., unless they are dot" is not incorrect
per-se, but perhaps rewriting the whole sentence, e.g. "Files and
directories in the template directory whose name do not start with a
dot will be copied to ...", may make it easier to read, I suspect.
next prev parent reply other threads:[~2017-02-17 22:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 9:31 dotfiles in git template dir are not copied greg0ire
2017-02-17 20:44 ` Jeff King
2017-02-17 21:42 ` Grégoire PARIS
2017-02-17 22:12 ` Junio C Hamano
2017-02-17 22:37 ` Grégoire PARIS
2017-02-17 22:44 ` Junio C Hamano
2017-02-17 23:39 ` Grégoire PARIS
2017-02-17 22:39 ` Philip Oakley
2017-02-17 22:49 ` Grégoire PARIS
2017-02-17 22:56 ` Junio C Hamano [this message]
2017-02-17 23:22 ` Grégoire PARIS
2017-02-17 23:30 ` Grégoire PARIS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk28opgsy.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=postmaster@greg0ire.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox