From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Git List <git@vger.kernel.org>,
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Stefan Beller <sbeller@google.com>,
Philip Oakley <philipoakley@iee.org>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit
Date: Tue, 02 Jun 2015 10:14:17 -0700 [thread overview]
Message-ID: <xmqqk2vm3udy.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqa8wiwo33.fsf@anie.imag.fr> (Matthieu Moy's message of "Tue, 02 Jun 2015 09:45:20 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Discussions on this list often lead to "Oh, BTW, shall we do XYZ also?",
> but you shouldn't take this kind of remark as blocking (as long as XYZ
> is not incompatible with your patch, which is the case here).
Yeah, thanks for clarification. As long as what is given to 'drop'
is checked when it matters (e.g. when the code in patch 2/2 tries
see if some commits in the original list are no longer there in
order to warn sees "drop foo bar" where "foo" is obviously not an
object name in the original list, that should be checked), it is
fine. And I agree 1/2 is not the place to do so, even though it may
be easier from the implementation point of view (which is why I
mentioned the possibility in the review of that patch).
next prev parent reply other threads:[~2015-06-02 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 9:57 [PATCH/RFCv2 0/2] rebase -i : drop command and removed commits Galan Rémi
2015-06-01 9:57 ` [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-01 16:39 ` Junio C Hamano
2015-06-01 17:06 ` Matthieu Moy
2015-06-01 17:45 ` Remi Galan Alfonso
2015-06-01 18:36 ` Matthieu Moy
2015-06-02 7:23 ` Remi Galan Alfonso
2015-06-02 7:45 ` Matthieu Moy
2015-06-02 17:14 ` Junio C Hamano [this message]
2015-06-03 9:13 ` Remi Galan Alfonso
2015-06-03 17:52 ` Junio C Hamano
2015-06-01 9:57 ` [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits Galan Rémi
-- strict thread matches above, loose matches on Subject: below --
2015-06-01 11:52 [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2vm3udy.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=johannes.schindelin@gmx.de \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=philipoakley@iee.org \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).