From: Junio C Hamano <gitster@pobox.com>
To: "Jason St. John" <jstjohn@purdue.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: use "command-line" when used as a compound adjective, and fix other minor grammatical issues
Date: Wed, 21 May 2014 12:06:28 -0700 [thread overview]
Message-ID: <xmqqk39fossr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1400698346-25949-1-git-send-email-jstjohn@purdue.edu> (Jason St. John's message of "Wed, 21 May 2014 14:52:26 -0400")
"Jason St. John" <jstjohn@purdue.edu> writes:
> diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt
> index 022e74e..01200ed 100644
> --- a/Documentation/user-manual.txt
> +++ b/Documentation/user-manual.txt
> @@ -173,13 +173,13 @@ index 65898fa..b002dc6 100644
> --- a/init-db.c
> +++ b/init-db.c
> @@ -7,7 +7,7 @@
> -
> +
> int main(int argc, char **argv)
> {
> - char *sha1_dir = getenv(DB_ENVIRONMENT), *path;
> + char *sha1_dir, *path;
> int len, i;
> -
> +
> if (mkdir(".git", 0755) < 0) {
> ------------------------------------------------
I know it would not make any difference either way when printed, but
aren't we showing how a typical diff output looks like with this
example, and each of these two otherwise blank lines should actually
be a line with a single SP on it?
Everything else looked fine. Thanks for cleaning the docs up.
prev parent reply other threads:[~2014-05-21 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 18:52 [PATCH] Documentation: use "command-line" when used as a compound adjective, and fix other minor grammatical issues Jason St. John
2014-05-21 19:02 ` Jason St. John
2014-05-21 19:16 ` Junio C Hamano
2014-05-21 19:06 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk39fossr.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jstjohn@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).