From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: Mirko Faina <mroik@delayed.space>,
git@vger.kernel.org, pabloosabaterr@gmail.com,
ben.knoble@gmail.com
Subject: Re: [PATCH v2] completions: add some missing options for git log
Date: Mon, 09 Nov 2026 12:21:37 -0800 [thread overview]
Message-ID: <xmqqld71ycvi.fsf@gitster.g> (raw)
In-Reply-To: <87wlqmxb9p.fsf@dev.null.iotcl.com.invalid> (Toon Claes's message of "Mon, 09 Nov 2026 16:41:38 +0100")
Toon Claes <toon@iotcl.com> writes:
> Mirko Faina <mroik@delayed.space> writes:
>
>> Some options for "git log" are missing in bash-completions,
>> --graph-lane-limit introduced in [1] and --[no-]graph-indent introduced
>> in [2].
>
> I'm fine with these changes, they do what we want them to. Looks good to
> me.
Yeah, this looks good to me, too. Thanks, both.
prev parent reply other threads:[~2026-11-09 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 19:50 [PATCH] bash-completions: add --[no-]graph-indent Mirko Faina
2026-10-29 12:16 ` Mirko Faina
2026-10-29 13:45 ` Pablo Sabater
2026-10-29 14:17 ` Ben Knoble
2026-11-02 19:53 ` Mirko Faina
2026-11-09 15:40 ` Toon Claes
2026-11-02 21:47 ` [PATCH v2] completions: add some missing options for git log Mirko Faina
2026-11-09 15:41 ` Toon Claes
2026-11-09 20:21 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqld71ycvi.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=mroik@delayed.space \
--cc=pabloosabaterr@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox