Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Orestis Floros <orestisflo@gmail.com>
Cc: git@vger.kernel.org,  Florian Schmidt <flosch@nutanix.com>,
	 Patrick Steinhardt <ps@pks.im>,
	 Philippe Blain <levraiphilippeblain@gmail.com>,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] commit-reach: parse commits in the given repository
Date: Wed, 16 Sep 2026 10:48:29 -0700	[thread overview]
Message-ID: <xmqqld91w0ia.fsf@gitster.g> (raw)
In-Reply-To: <20260916134632.1424829-1-orestisflo@gmail.com> (Orestis Floros's message of "Wed, 16 Sep 2026 15:46:31 +0200")

Orestis Floros <orestisflo@gmail.com> writes:

> ...
> The latter used to be the only symptom. Before bb5da75d61 (commit: use
> commit graph in `lookup_commit_reference_gently()`, 2026-02-16) the
> initial lookup did not record commit-graph positions, so the walk simply
> failed to find the submodule commits in the superproject:
>
>     error: Could not read <commit>
>     Failed to merge submodule sub (commits don't follow merge-base)
>
> Pass the repository into both functions. git-fetch-pack(1) and
> git-upload-pack(1) keep passing `the_repository`.

That's reasonable.  It is a very welcome change that aligns with
recent libification efforts.

Will queue.

Thanks.

  parent reply	other threads:[~2026-09-16 17:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  9:05 [BUG] "commit graph is likely corrupt" on git rebase Florian Schmidt
2026-08-10 13:43 ` Patrick Steinhardt
2026-09-16 13:46 ` [PATCH] commit-reach: parse commits in the given repository Orestis Floros
2026-09-16 14:55   ` Kristofer Karlsson
2026-09-16 17:48   ` Junio C Hamano [this message]
2026-09-23 12:49   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqld91w0ia.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=flosch@nutanix.com \
    --cc=git@vger.kernel.org \
    --cc=levraiphilippeblain@gmail.com \
    --cc=newren@gmail.com \
    --cc=orestisflo@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox