From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] last-modified: document option --max-depth
Date: Wed, 26 Nov 2025 11:49:22 -0800 [thread overview]
Message-ID: <xmqqldjsmv5p.fsf@gitster.g> (raw)
In-Reply-To: <20251126-toon-last-modified-zzzz-v1-2-608350df0caa@iotcl.com> (Toon Claes's message of "Wed, 26 Nov 2025 07:09:44 +0100")
Toon Claes <toon@iotcl.com> writes:
> Option --max-depth is supported by git-last-modified(1), because it was
> added to the diff machinery in a1dfa5448d (diff: teach tree-diff a
> max-depth parameter, 2025-08-07).
>
> This option is useful for everyday use of the git-last-modified(1)
> command, so document it's existence in the man page and `-h` output.
>
> Signed-off-by: Toon Claes <toon@iotcl.com>
> ---
> Documentation/git-last-modified.adoc | 9 ++++++++-
> builtin/last-modified.c | 12 +++++++++++-
> 2 files changed, 19 insertions(+), 2 deletions(-)
Does this step pass t0450?
fixup! last-modified: document option --max-depth
diff --git a/builtin/last-modified.c b/builtin/last-modified.c
index ccb7ff66d4..857554e70d 100644
--- a/builtin/last-modified.c
+++ b/builtin/last-modified.c
@@ -523,8 +523,8 @@ int cmd_last_modified(int argc, const char **argv, const char *prefix,
struct last_modified lm = LAST_MODIFIED_INIT;
const char * const last_modified_usage[] = {
- N_("git last-modified [--recursive] [--show-trees] [--max-depth=<depth>] [-z] "
- "[<revision-range>] [[--] <path>...]"),
+ N_("git last-modified [--recursive] [--show-trees] [--max-depth=<depth>] [-z]\n"
+ " [<revision-range>] [[--] <path>...]"),
NULL
};
next prev parent reply other threads:[~2025-11-26 19:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 6:09 [PATCH 0/3] Expand and enhance git-last-modified(1) documentation Toon Claes
2025-11-26 6:09 ` [PATCH 1/3] last-modified: handle and document NUL termination Toon Claes
2025-11-26 13:03 ` Karthik Nayak
2025-11-26 16:57 ` Junio C Hamano
2025-11-28 18:50 ` Toon Claes
2025-12-01 10:32 ` Patrick Steinhardt
2025-11-26 6:09 ` [PATCH 2/3] last-modified: document option --max-depth Toon Claes
2025-11-26 13:31 ` Karthik Nayak
2025-11-26 19:49 ` Junio C Hamano [this message]
2025-11-28 18:51 ` Toon Claes
2025-11-26 6:09 ` [PATCH 3/3] last-modified: better document how depth in handled Toon Claes
2025-11-26 17:38 ` Eric Sunshine
2025-12-01 10:32 ` Patrick Steinhardt
2025-12-02 11:01 ` Toon Claes
2025-12-02 17:14 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldjsmv5p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).