From: Junio C Hamano <gitster@pobox.com>
To: Mike Rappazzo <rappazzo@gmail.com>
Cc: git@vger.kernel.org, j6t@kdbg.org
Subject: Re: [PATCH gitk] gitk: add README.md with contribution guidelines
Date: Wed, 20 Aug 2025 14:12:31 -0700 [thread overview]
Message-ID: <xmqqldnd8zpc.fsf@gitster.g> (raw)
In-Reply-To: <CANoM8SVTROfaQpRNBfwxU9opjXFPLzxN1W-xXTrA2bhx9KJ0LQ@mail.gmail.com> (Mike Rappazzo's message of "Wed, 20 Aug 2025 17:02:47 -0400")
Mike Rappazzo <rappazzo@gmail.com> writes:
> On Wed, Aug 20, 2025 at 4:57 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Michael Rappazzo <rappazzo@gmail.com> writes:
>>
>> > +#### Creating and Sending Patches
>> > +After committing your changes:
>> > +```bash
>> > +git format-patch -1 --subject-prefix="PATCH gitk"
>> > +git send-email --to=git@vger.kernel.org --cc=j6t@kdbg.org *.patch
>> > +```
>>
>> Just being curious, but does the project strongly discourage a
>> multi-patch topic?
>
> I don't believe so. I think most people know how to submit a github
> PR, but J6t has mentioned that he prefers the mailing list (as noted
> in the readme). So I wrote a simple example to show that patching by
> email doesn't have to be scary.
As the original assumes that you are on the branch where you are
taking the patch(es) from, perhaps
$ git format-patch --subject-prefix='PATCH gitk' @{u}..
would work? I was mostly reacting to the "-1" on the command line.
>> It would be really nice if you add "review them here before you run
>> send-email" step between these two commands ;-).
>
> I can revise. I will wait for more comments before sending a v2.
Thanks.
next prev parent reply other threads:[~2025-08-20 21:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 19:52 [PATCH gitk] gitk: add README.md with contribution guidelines Michael Rappazzo
2025-08-20 20:57 ` Junio C Hamano
2025-08-20 21:02 ` Mike Rappazzo
2025-08-20 21:12 ` Junio C Hamano [this message]
2025-08-20 21:20 ` Mike Rappazzo
2025-08-20 23:42 ` D. Ben Knoble
2025-08-20 21:03 ` Kristoffer Haugsbakk
2025-08-20 21:15 ` Junio C Hamano
2025-08-21 7:15 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldnd8zpc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=rappazzo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).