From: Junio C Hamano <gitster@pobox.com>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2025, #07; Thu, 24)
Date: Sat, 26 Jul 2025 10:45:18 -0700 [thread overview]
Message-ID: <xmqqldoa26dt.fsf@gitster.g> (raw)
In-Reply-To: <CAPSxiM9Udi2PxpT7f8DdLn1ihny2gW_H=ieLjV25sEFYSdAjMQ@mail.gmail.com> (Usman Akinyemi's message of "Sat, 26 Jul 2025 07:33:31 +0530")
Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
> On Thu, Jul 24, 2025 at 10:48 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>...
Administrivia. NEVER QUOTE SO MANY LINES from the original if your
response has nothing to say about them. Remove the part you are not
commenting on and leave only the relevant parts that you are about
to respond, and then say your thing.
>> * ua/t1517-short-help-tests (2025-07-21) 2 commits
>> . t5200: move `update-server-info -h` test from t1517
>> . t/t1517: automate `git subcmd -h` tests outside a repository
>>
>> Test shuffling.
>>
>> Seems to introduce a few "todo passed" when merged to 'seen'.
> Hi Junio,
>
> Is there something that needs to be done here ?
>
> Also, some tests still have both the `git subcmd -h` test outside and
> inside together
> and the first patch of this series already tests for all the outside repo.
>
> Should I send them as an update version with this patch or wait till
> this gets integrated ?
As I wrote, with this merged to 'seen', we see "todo passed" in the
test result. You'd want to dig to the root cause of the issue and
update the patches if needed.
> Thank you
>
>> source: <20250721115519.140361-1-usmanakinyemi202@gmail.com>
>>
>>
Also do not leave the original that you are not going to refer to
after you finish saying what you wanted to say.
>> * kn/for-each-ref-skip (2025-07-23) 6 commits
>> - ref-iterator-seek: correctly initialize the prefix_state for a new level
>>...
Thanks.
next prev parent reply other threads:[~2025-07-26 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 17:18 What's cooking in git.git (Jul 2025, #07; Thu, 24) Junio C Hamano
2025-07-26 2:03 ` Usman Akinyemi
2025-07-26 13:00 ` D. Ben Knoble
2025-07-27 0:00 ` Junio C Hamano
2025-07-26 17:45 ` Junio C Hamano [this message]
2025-07-26 21:27 ` Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldoa26dt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).