From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH] strbuf: add compound literal test balloon
Date: Wed, 23 Jul 2025 11:01:52 -0700 [thread overview]
Message-ID: <xmqqldoen5v3.fsf@gitster.g> (raw)
In-Reply-To: <ecca4252-1c29-4661-a454-a4cedc28bead@gmail.com> (Phillip Wood's message of "Wed, 16 Jul 2025 15:29:51 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
> On 15/07/2025 17:24, Junio C Hamano wrote:
>> That sounds good. I was wondering if it is easier to keep track of
>> things to add a new section to the CodingGuildlines document,
>> perhaps like this?
>
> That's a good idea
>
> Thanks
>
> Phillip
I guess I dropped the ball after this exchange. So our tentative
conclusion was to drop your new test balloon, and replace it with
the documentation patch you are responding to, which I obviously
am OK with.
Let me make it happen.
Thanks.
>
>> Documentation/CodingGuidelines | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> diff --git c/Documentation/CodingGuidelines
>> w/Documentation/CodingGuidelines
>> index 6350949f2e..dd3dbb9c57 100644
>> --- c/Documentation/CodingGuidelines
>> +++ w/Documentation/CodingGuidelines
>> @@ -298,6 +298,14 @@ For C programs:
>> . since late 2021 with 44ba10d6, we have had variables declared in
>> the for loop "for (int i = 0; i < 10; i++)".
>> + C99 features we have test balloons for:
>> +
>> + . since late 2024 with v2.48.0-rc0~20, we have test balloons for
>> + compound literal syntax, e.g., (struct foo){ .member = value };
>> + our hope is that no platforms we care about have trouble using
>> + them, and officially adopt its wider use in mid 2026. Do not add
>> + more use of the syntax until that happens.
>> +
>> New C99 features that we cannot use yet:
>> . %z and %zu as a printf() argument for a size_t (the %z
>> being for
next prev parent reply other threads:[~2025-07-23 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:27 [PATCH] strbuf: add compound literal test balloon Phillip Wood
2025-07-14 14:26 ` Junio C Hamano
2025-07-15 8:53 ` Patrick Steinhardt
2025-07-15 9:44 ` Phillip Wood
2025-07-15 16:24 ` Junio C Hamano
2025-07-16 14:29 ` Phillip Wood
2025-07-23 18:01 ` Junio C Hamano [this message]
2025-07-23 19:31 ` [PATCH] CodingGuidelines: document test balloons in flight Junio C Hamano
2025-07-24 6:55 ` Patrick Steinhardt
2025-07-24 16:39 ` Junio C Hamano
2025-07-24 16:55 ` Collin Funk
2025-07-26 23:15 ` Junio C Hamano
2025-07-24 14:26 ` Phillip Wood
2025-07-24 16:23 ` Junio C Hamano
2025-07-16 14:32 ` [PATCH] strbuf: add compound literal test balloon Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldoen5v3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).