From: Junio C Hamano <gitster@pobox.com>
To: "Lidong Yan via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Lidong Yan <502024330056@smail.nju.edu.cn>
Subject: Re: [PATCH v2] revision: fix memory leak in prepare_show_merge()
Date: Mon, 09 Jun 2025 13:48:01 -0700 [thread overview]
Message-ID: <xmqqldq0prpa.fsf@gitster.g> (raw)
In-Reply-To: <pull.1989.v2.git.git.1749456990648.gitgitgadget@gmail.com> (Lidong Yan via GitGitGadget's message of "Mon, 09 Jun 2025 08:16:30 +0000")
"Lidong Yan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> +test_expect_success 'show unmerged index' '
> + git reset --hard &&
We use tabs for indent.
> +
> + git switch -C base &&
> + echo "base" > conflicting &&
Let's lose the SP between redirection operator ">" and its target
"conflicting", i.e.
echo "base" >conflicting &&
> + git add conflicting &&
> + git commit -m "base" &&
> +
> + git branch hello &&
> + git branch goodbye &&
> +
> + git switch hello &&
> + echo "hello" > conflicting &&
> + git commit -am "hello" &&
> +
> + git switch goodbye &&
> + echo "goodbye" > conflicting &&
> + git commit -am "goodbye" &&
> +
> + git switch hello &&
> + test_must_fail git merge goodbye &&
> + git show --merge HEAD
> +'
> +
> test_done
>
> base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67
next prev parent reply other threads:[~2025-06-09 20:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 3:08 [PATCH] revision: fix memory leak in prepare_show_merge() Lidong Yan via GitGitGadget
2025-06-04 7:48 ` Patrick Steinhardt
2025-06-04 7:53 ` lidongyan
2025-06-04 8:06 ` Patrick Steinhardt
2025-06-04 10:25 ` lidongyan
2025-06-05 20:56 ` Junio C Hamano
2025-06-06 7:31 ` lidongyan
2025-06-06 16:47 ` Junio C Hamano
2025-06-09 3:10 ` lidongyan
2025-06-09 8:16 ` [PATCH v2] " Lidong Yan via GitGitGadget
2025-06-09 20:48 ` Junio C Hamano [this message]
2025-06-10 0:37 ` [PATCH v3] " Lidong Yan via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldq0prpa.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=502024330056@smail.nju.edu.cn \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).