From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] GitHub ci(windows): speed up initializing Git for Windows' minimal SDK again
Date: Tue, 17 Dec 2024 12:33:10 -0800 [thread overview]
Message-ID: <xmqqldweyrqx.fsf@gitster.g> (raw)
In-Reply-To: <pull.1841.git.1734447458896.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Tue, 17 Dec 2024 14:57:38 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> This commit partially reverts 91839a88277 (ci: create script to set up
> Git for Windows SDK, 2024-10-09).
Thanks, will queue.
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 9301a1edd6d..916a64b6736 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -113,15 +113,13 @@ jobs:
> cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}
> steps:
> - uses: actions/checkout@v4
> - - name: setup SDK
> - shell: powershell
> - run: ci/install-sdk.ps1
> + - uses: git-for-windows/setup-git-for-windows-sdk@v1
> - name: build
> - shell: powershell
> + shell: bash
> env:
> HOME: ${{runner.workspace}}
> NO_PERL: 1
> - run: git-sdk/usr/bin/bash.exe -l -c 'ci/make-test-artifacts.sh artifacts'
> + run: . /etc/profile && ci/make-test-artifacts.sh artifacts
> - name: zip up tracked files
> run: git archive -o artifacts/tracked.tar.gz HEAD
> - name: upload tracked files and build artifacts
> @@ -149,12 +147,10 @@ jobs:
> - name: extract tracked files and build artifacts
> shell: bash
> run: tar xf artifacts.tar.gz && tar xf tracked.tar.gz
> - - name: setup SDK
> - shell: powershell
> - run: ci/install-sdk.ps1
> + - uses: git-for-windows/setup-git-for-windows-sdk@v1
> - name: test
> - shell: powershell
> - run: git-sdk/usr/bin/bash.exe -l -c 'ci/run-test-slice.sh ${{matrix.nr}} 10'
> + shell: bash
> + run: . /etc/profile && ci/run-test-slice.sh ${{matrix.nr}} 10
> - name: print test failures
> if: failure() && env.FAILED_TEST_ARTIFACTS != ''
> shell: bash
>
> base-commit: 631ddbbcbd912530e1b78e5d782e72879f7f1fb2
next prev parent reply other threads:[~2024-12-17 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 14:57 [PATCH] GitHub ci(windows): speed up initializing Git for Windows' minimal SDK again Johannes Schindelin via GitGitGadget
2024-12-17 20:33 ` Junio C Hamano [this message]
2024-12-18 5:56 ` Patrick Steinhardt
2024-12-19 13:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldweyrqx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).