From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, karthik nayak <karthik.188@gmail.com>
Subject: Re: [PATCH v2] bundle: remove unneeded code
Date: Thu, 12 Dec 2024 17:08:02 +0900 [thread overview]
Message-ID: <xmqqldwlfhnh.fsf@gitster.g> (raw)
In-Reply-To: <87y10mhrfe.fsf@iotcl.com> (Toon Claes's message of "Wed, 11 Dec 2024 21:53:57 +0100")
Toon Claes <toon@iotcl.com> writes:
>> # false &&
>> # test_cmp expect actual
>> #
>> 1..17
>>
>> What's the "false" doing here?
>
> I'm terribly sorry, how sloppy of me.
Heh, let's not over-react (applies on both sides; I should also have
stopped, took a deep breath, possibly try to remove it and see if it
makes sense myself, before asking that question in a hostile tone,
sorry). Mistakes happen.
> I added that during debugging to
> be able to inspect the t/trash* directory. This shouldn't have made it
> to the final patch. My apologies, I've submitted v3 which doesn't
> include that line.
Thanks, will replace.
next prev parent reply other threads:[~2024-12-12 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 9:28 [PATCH v2] bundle: remove unneeded code Toon Claes
2024-12-11 15:07 ` Junio C Hamano
2024-12-11 20:53 ` Toon Claes
2024-12-12 8:08 ` Junio C Hamano [this message]
2024-12-11 20:51 ` [PATCH v3] " Toon Claes
2024-12-12 10:11 ` karthik nayak
2024-12-13 3:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldwlfhnh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).