git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kai Koponen <kaikoponen@google.com>
Cc: git@vger.kernel.org,  Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] doc: mention rev-list --ancestry-path restrictions
Date: Wed, 04 Dec 2024 08:24:56 +0900	[thread overview]
Message-ID: <xmqqldww9won.fsf@gitster.g> (raw)
In-Reply-To: <CADYQcGrD5KtM1sZQbccAtDaLmUXD8Gxv_nUWmapjfZm=TMq=Jw@mail.gmail.com> (Kai Koponen's message of "Tue, 3 Dec 2024 12:14:34 -0500")

Kai Koponen <kaikoponen@google.com> writes:

> The rev-list documentation doesn't mention that the given
> commit must be in the specified commit range, leading
> to unexpected results.
>
> Signed-off-by: Kai Koponen <kaikopone@google.com>
> ---
>  Documentation/rev-list-options.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/rev-list-options.txt
> b/Documentation/rev-list-options.txt
> index 00ccf68744..f0a46f9da5 100644
> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -412,7 +412,7 @@ Default mode::
>
>  --ancestry-path[=<commit>]::
>   When given a range of commits to display (e.g. 'commit1..commit2'
> - or 'commit2 {caret}commit1'), only display commits in that range
> + or 'commit2 {caret}commit1'), and a commit <commit> in that range,
> only display commits in that range
>   that are ancestors of <commit>, descendants of <commit>, or
>   <commit> itself.  If no commit is specified, use 'commit1' (the
>   excluded part of the range) as <commit>.  Can be passed multiple

Thanks for accomodating my pickyness ;-)  This version reads very
well.

Will queue.


  parent reply	other threads:[~2024-12-03 23:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19 21:53 rev-list --ancestry-path with arg - bug or undocumented requirement Kai Koponen
2024-11-20  3:22 ` Elijah Newren
2024-12-02 19:45   ` Kai Koponen
2024-12-02 23:48     ` Elijah Newren
2024-12-03  1:05     ` Junio C Hamano
2024-12-03 17:14       ` [PATCH] doc: mention rev-list --ancestry-path restrictions Kai Koponen
2024-12-03 17:38         ` Kristoffer Haugsbakk
2024-12-03 17:59           ` Kai Koponen
2024-12-03 20:21             ` Kai Koponen
2024-12-03 23:33           ` Junio C Hamano
2024-12-03 23:36             ` Kai Koponen
2024-12-03 23:24         ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-12-03 20:18 Kai Koponen via GitGitGadget
2024-12-03 22:22 ` Elijah Newren
2024-12-04  0:10 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqldww9won.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kaikoponen@google.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).