git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "Sören Krecker" <soekkle@freenet.de>,
	git@vger.kernel.org, tboegi@web.de, phillip.wood@dunelm.org.uk
Subject: Re: [PATCH v2 1/1] [PATCH] mimgw: remove Compiler Warnings
Date: Thu, 10 Oct 2024 09:08:57 -0700	[thread overview]
Message-ID: <xmqqldywlz3a.fsf@gitster.g> (raw)
In-Reply-To: <e7646092-84e0-4210-88e9-98352e1f60e0@gmail.com> (Phillip Wood's message of "Thu, 10 Oct 2024 09:59:18 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> Thanks for re-rolling, I think "Fix some compiler warnings" would be
> clearer than "Remove", also "integers" is misspelt.

Though "Fix" is a word with less information than other words we
could use.  The changes in the patch are primarily about mismatched
type, so perhaps

    mingw: use size_t insead of int for lengths
      
would make a better commit title.

I agree with everything you said including this part:

> It would also be helpful to explain in the commit message the changes
> to _ssize_t
>
>> +#ifdef _WIN64
>> +typedef __int64 _ssize_t;
>> +#else
>>   typedef long _ssize_t;
>> +#endif // _AMD64
>
> Please note that we do not use "//" comments so this should be "/*
> _WIN64 */" so that the comment matches the opening #ifdef
>
> Thanks for working on this

Thanks.

      parent reply	other threads:[~2024-10-10 16:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 10:35 [PATCH] mimgw: remove Compiler Warnings Sören Krecker
2024-10-09 15:26 ` Torsten Bögershausen
2024-10-09 16:13 ` Phillip Wood
2024-10-09 17:13   ` Sören Krecker
2024-10-09 17:13     ` [PATCH v2 1/1] " Sören Krecker
2024-10-09 18:20       ` Junio C Hamano
2024-10-10  8:59       ` Phillip Wood
2024-10-10 10:29         ` [PATCH] [PATCH] mimgw: Remove " Sören Krecker
2024-10-10 19:19           ` Torsten Bögershausen
2024-10-12  6:22             ` [PATCH v4] mingw.c: Fix complier warnings for a 64 bit msvc Sören Krecker
2024-10-16 16:51               ` Torsten Bögershausen
2024-10-16 20:22               ` Taylor Blau
2024-10-17 17:18                 ` [PATCH v5 0/1] " Sören Krecker
2024-10-17 17:18                   ` [PATCH 1/1] [PATCH] " Sören Krecker
2024-10-17 18:43                     ` Taylor Blau
2024-10-10 16:08         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqldywlz3a.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=soekkle@freenet.de \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).