git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
	Yukai Chou <muzimuzhi@gmail.com>
Subject: Re: [PATCH v2] doc: add --show-names for git config
Date: Mon, 19 Aug 2024 12:22:49 -0700	[thread overview]
Message-ID: <xmqqle0se2ra.fsf@gitster.g> (raw)
In-Reply-To: <CAEg0tHQDT7LesB2kiQD4rXwcUs5ZhOH+YWdn990tfGdrnYdgZg@mail.gmail.com> (Yukai Chou's message of "Tue, 20 Aug 2024 02:27:56 +0800")

[Cc-ing the author of 4e513890 that was referred to by this change.]

Yukai Chou <muzimuzhi@gmail.com> writes:

> 4e513890 (builtin/config: introduce "get" subcommand,
> 2024-05-06) introduced "--show-names" option that is used to
> give the name of the configuration variable to each output entry
> in addition to the value.  It however forgot to document it,
> even though the option is used in a few examples.
>
> Document it.
>
> Signed-off-by: Yukai Chou <muzimuzhi@gmail.com>
> ---
> Thanks for your review and suggestions Junio. I must have stayed up
> too late yesterday, so what the commit message was sent was not the
> final version.
>
>  Documentation/git-config.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index 65c645d461..16323c4ed0 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -268,6 +268,9 @@ Valid `<type>`'s include:
>   all queried config options with the scope of that value
>   (worktree, local, global, system, command).
>
> +--show-names::
> + Output also the names of config variables for `list` or `get`.
> +
>  --get-colorbool <name> [<stdout-is-tty>]::
>
>   Find the color setting for `<name>` (e.g. `color.diff`) and output

  reply	other threads:[~2024-08-19 19:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19  0:45 [PATCH] doc: add --show-names for git config Yukai Chou
2024-08-19  0:59 ` Yukai Chou
2024-08-19 16:04 ` Junio C Hamano
2024-08-19 18:27   ` [PATCH v2] " Yukai Chou
2024-08-19 19:22     ` Junio C Hamano [this message]
2024-08-21  6:53     ` Patrick Steinhardt
2024-08-21 16:01       ` Junio C Hamano
2024-08-21  6:53   ` [PATCH] " Patrick Steinhardt
2024-08-21 16:02     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqle0se2ra.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=muzimuzhi@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).