From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH] builtin/ls-remote: fall back to SHA1 outside of a repo
Date: Fri, 02 Aug 2024 08:26:45 -0700 [thread overview]
Message-ID: <xmqqle1feyiy.fsf@gitster.g> (raw)
In-Reply-To: <c52112d3946b2fd8d030580cd7acb809fa54012a.1722573777.git.ps@pks.im> (Patrick Steinhardt's message of "Fri, 2 Aug 2024 06:44:11 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I didn't spot this in the "What's cooking" report. I guess that's my own
> fault for not sending it as a proper patch, so let me fix that now :)
Yeah, I had a fix already when I gave my response to the initial
problem report, but felt that it was too premature to commit to the
approach before listening to others (you included) for potentially
better alternative approaches, and then forgot about it.
The fix here is in line with my thoughts, after seeing how other
parts of the transport work. Thanks for tying the loose ends.
prev parent reply other threads:[~2024-08-02 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-27 19:19 [2.46 regression] git ls-remote crash with import remote-helper Mike Hommey
2024-07-28 3:54 ` Junio C Hamano
2024-07-29 15:41 ` Patrick Steinhardt
2024-07-29 17:18 ` Junio C Hamano
2024-08-02 4:44 ` [PATCH] builtin/ls-remote: fall back to SHA1 outside of a repo Patrick Steinhardt
2024-08-02 15:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqle1feyiy.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).