git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Alexander Shopov <ash@kambanaria.org>,
	 git@vger.kernel.org, worldhello.net@gmail.com
Subject: Re: [PATCH  1/1] show-ref: improve short help messages of options
Date: Fri, 26 Jul 2024 08:46:32 -0700	[thread overview]
Message-ID: <xmqqle1oxijr.fsf@gitster.g> (raw)
In-Reply-To: <ZqOWUrynjUN2A5TM@tanuki> (Patrick Steinhardt's message of "Fri, 26 Jul 2024 14:28:02 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> Meanwhile, I think that the proposed change strictly improves this
> message and thus don't see a reason not to take it. Unless we see
> somebody come up with a less-awkward solution, that is.

Oh, that part is uncontroversial.

The wording without double-dashes has been with us forever since the
command was updated to use the parse-options API by 69932bc6
(show-ref: migrate to parse-options, 2009-06-20), and so far nobody
complained about it, so while "strictly improves" may be true (i.e.
the delta may not be negative), the degree of improvement may not be
all that much to be worth the combined brain cycles we are spending
on this topic.  Taking the patch would not make the future work any
harder to truly improve it further, so I do not see any reason not
to take it.

Thanks.




      reply	other threads:[~2024-07-26 15:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 11:11 [PATCH 1/1] show-ref: improve short help messages of options Alexander Shopov
2024-07-25  7:15 ` Patrick Steinhardt
2024-07-25 15:03   ` Junio C Hamano
2024-07-26 12:28     ` Patrick Steinhardt
2024-07-26 15:46       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqle1oxijr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ash@kambanaria.org \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).