From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
Taylor Blau <me@ttaylorr.com>, John Cai <johncai86@gmail.com>,
Dhruva Krishnamurthy <dhruvakm@gmail.com>
Subject: Re: [PATCH] attr.tree: HEAD:.gitattributes is no longer the default in a bare repo
Date: Thu, 06 Jun 2024 09:02:44 -0700 [thread overview]
Message-ID: <xmqqle3injob.fsf@gitster.g> (raw)
In-Reply-To: <20240606083216.GE658959@coredump.intra.peff.net> (Jeff King's message of "Thu, 6 Jun 2024 04:32:16 -0400")
Jeff King <peff@peff.net> writes:
> I think 51441e64 is essentially a revert of 2386535511 (attr: read
> attributes from HEAD when bare repo, 2023-10-13). I don't know how you
> prepared it, but I'd probably have started with "cherry-pick -n". But
> that wouldn't help, because the documentation didn't come until after
> that in 9f9c40cf34 (attr: add attr.tree for setting the treeish to read
> attributes from, 2023-10-13).
"revert -m 1" followed by "commit --amend" might have worked well in
this case to get rid of the code that came from one and doc update
that came from the other in a two patch series, but in general, that
would be too much noise to wade through in general.
> Not that it really matters much now, but always just curious about how
> we can avoid missing stuff like this next time.
The series first did "HEAD tree is used in bare" without doc, and
followed up with "configuration can be used to name any tree" with
doc that mentions the behaviour of the first step as a special case
of default value for the configuration variable. The only way it
could have been made easier to spot is to introduce the variable
with documentation first, and then do the "bare repo uses HEAD as
the default" thing on top.
next prev parent reply other threads:[~2024-06-06 16:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 5:26 Help troubleshoot performance regression cloning with depth: git 2.44 vs git 2.42 Dhruva Krishnamurthy
2024-05-01 22:00 ` using tree as attribute source is slow, was " Jeff King
2024-05-01 22:37 ` rsbecker
2024-05-01 22:40 ` Junio C Hamano
2024-05-02 0:33 ` Taylor Blau
2024-05-02 17:33 ` Taylor Blau
2024-05-02 17:44 ` Junio C Hamano
2024-05-02 17:55 ` Taylor Blau
2024-05-02 19:01 ` Karthik Nayak
2024-05-02 21:08 ` Junio C Hamano
2024-05-03 5:37 ` Dhruva Krishnamurthy
2024-05-03 15:34 ` Re* " Junio C Hamano
2024-05-03 17:46 ` Jeff King
2024-05-06 20:28 ` Taylor Blau
2024-05-13 20:16 ` John Cai
2024-06-05 21:43 ` [PATCH] attr.tree: HEAD:.gitattributes is no longer the default in a bare repo Junio C Hamano
2024-06-06 8:32 ` Jeff King
2024-06-06 16:02 ` Junio C Hamano [this message]
2024-05-02 18:34 ` using tree as attribute source is slow, was Re: Help troubleshoot performance regression cloning with depth: git 2.44 vs git 2.42 Dhruva Krishnamurthy
2024-05-02 0:45 ` Dhruva Krishnamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqle3injob.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dhruvakm@gmail.com \
--cc=git@vger.kernel.org \
--cc=johncai86@gmail.com \
--cc=karthik.188@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).