git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Haritha via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Haritha D <Harithamma.D@ibm.com>,
	 Ghanshyam Thakkar <shyamthakkar001@gmail.com>,
	 rsbecker@nexbridge.com
Subject: Re: [PATCH v4] build: support z/OS (OS/390).
Date: Wed, 06 Mar 2024 08:10:23 -0800	[thread overview]
Message-ID: <xmqqle6vtk7k.fsf@gitster.g> (raw)
In-Reply-To: <pull.1663.v4.git.git.1709703857881.gitgitgadget@gmail.com> (Haritha via GitGitGadget's message of "Wed, 06 Mar 2024 05:44:17 +0000")

"Haritha  via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Haritha D <harithamma.d@ibm.com>
>
> Introduced z/OS (OS/390) as a platform in config.mak.uname
>
> Signed-off-by: Haritha D <harithamma.d@ibm.com>
> ---
>     This PR enables a successful git build on z/OS.

Good.

>  config.mak.uname | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index dacc95172dc..d0dcca2ec55 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>  	SANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin
>  	SHELL_PATH = /usr/coreutils/bin/bash
>  endif
> +ifeq ($(uname_S),OS/390)
> +	NO_SYS_POLL_H = YesPlease
> +	NO_STRCASESTR = YesPlease
> +	NO_REGEX = YesPlease
> +	NO_MMAP = YesPlease
> +	NO_NSEC = YesPlease
> +	NO_STRLCPY = YesPlease
> +	NO_MEMMEM = YesPlease
> +	NO_GECOS_IN_PWENT = YesPlease
> +	HAVE_STRINGS_H = YesPlease
> +	NEEDS_MODE_TRANSLATION = YesPlease
> +endif

I somehow expected you to throw in the -L thing in this block,
perhaps like

	CC_LD_DYNPATH =

to help those who are on OS/390 but do not run configure (made from
configure.ac) to create the config.mak.autogen file, but if you are
always building with configure and not testing such a configuration,
then doing so and shipping an untested code would not be prudent, so
let's accept this patch as-is.

Thanks for working on this.  Will queue.

      reply	other threads:[~2024-03-06 16:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 14:21 [PATCH] This PR enables a successful git build on z/OS Haritha  via GitGitGadget
2024-01-31 16:12 ` Kristoffer Haugsbakk
2024-01-31 17:58   ` Junio C Hamano
2024-01-31 17:12 ` Junio C Hamano
2024-02-23  3:48 ` [PATCH v2 0/2] " Haritha  via GitGitGadget
2024-02-23  3:48   ` [PATCH v2 1/2] build: support z/OS (OS/390) Haritha D via GitGitGadget
2024-02-23  3:48   ` [PATCH v2 2/2] an improvement: removed configure.ac changes Haritha D via GitGitGadget
2024-02-23  7:38     ` Junio C Hamano
2024-02-23  7:37   ` [PATCH v2 0/2] This PR enables a successful git build on z/OS Junio C Hamano
2024-02-25  6:10   ` [PATCH v3] build: support z/OS (OS/390) Haritha  via GitGitGadget
2024-02-26 17:30     ` Junio C Hamano
2024-03-01  9:09       ` Haritha D
2024-03-01 14:39         ` Ghanshyam Thakkar
2024-03-01 18:15         ` Junio C Hamano
2024-03-01 18:25           ` rsbecker
2024-03-04  4:19             ` Haritha D
2024-03-06  5:44     ` [PATCH v4] " Haritha  via GitGitGadget
2024-03-06 16:10       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqle6vtk7k.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Harithamma.D@ibm.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=rsbecker@nexbridge.com \
    --cc=shyamthakkar001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).