From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 315BD3F9C5 for ; Mon, 29 Jan 2024 17:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.108.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706549164; cv=none; b=h/lObgT8cAg9sjTTXEtOIJHwu4aPkGimrKdMGfGFwqi5RjL9ZnpL+rBIA1H/NQESjIvhETJ8YPOW4FjCFgntYNfg1tIe5WwDkPjAIqh9TzfMdDHxCBCSS9AhzKfBtvO4fbcIPOAFgBGf3WINdwNxbqs9HEVh9yXlZAt5uJdXHQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706549164; c=relaxed/simple; bh=acxo/BU4fa1Pgg3YjpDMEe4aKvVFh0rZL3hD2gh2Cqo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=aq4npF81SKZw/F2v1ubmL5uqVYkRh8yZ7u+UuVD/jnbpOnPTPKCSYEhGeunLbybDoy0YhHteJzNErcYscu0qNFztc2OjQCBEU6P28D6YX4uMK+6JcQhUT+8po923AwoFrPN0VEbwEndadctEebBZ6b0K/EFiYUhOFKxqCdBt6KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=K+UPJjb5; arc=none smtp.client-ip=64.147.108.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="K+UPJjb5" Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 395EF1D6C2B; Mon, 29 Jan 2024 12:25:56 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=acxo/BU4fa1Pgg3YjpDMEe4aKvVFh0rZL3hD2g h2Cqo=; b=K+UPJjb5LWDyUQhhgFbaZKfD2E8rzFrEftCnFY/B70NbYlZjLOrH2B gkKqh8CT/S7xbtdYXN+rHKnPCRm63mKZ21ZPuKJkbT9gz/5Oa+HcRBROe3I59fce M0yRGsUsPV0uvAwons3BBzBzc+hdm4CQ1Nhp/xmjJWzk28oKTSl44= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 30AD61D6C2A; Mon, 29 Jan 2024 12:25:56 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.200.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 9862D1D6C29; Mon, 29 Jan 2024 12:25:55 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "James Touton via GitGitGadget" Cc: git@vger.kernel.org, James Touton Subject: Re: [PATCH v2] git-p4: use raw string literals for regular expressions In-Reply-To: (James Touton via GitGitGadget's message of "Fri, 26 Jan 2024 23:41:36 +0000") References: Date: Mon, 29 Jan 2024 09:25:54 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 75A458AE-BECB-11EE-B7EB-78DCEB2EC81B-77302942!pb-smtp1.pobox.com "James Touton via GitGitGadget" writes: > From: James Touton > > Fixes several Python diagnostics about invalid escape sequences. The > diagnostics appear for me in Python 3.12, and may appear in earlier > versions. The fix is to use raw string literals so that backslashes are > not interpreted as introducing escape sequences. Raw string literals > are already in use in this file, so adding more does not impact > toolchain compatibility. > > Signed-off-by: James Touton > --- > git-p4: use raw string literals for regular expressions > > Changes since v1: > > * Updated commit message to include the Python version where the > diagnostics were observed. > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1639%2FBekenn%2Fp4-raw-strings-v2 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1639/Bekenn/p4-raw-strings-v2 > Pull-Request: https://github.com/gitgitgadget/git/pull/1639 > > Range-diff vs v1: > > 1: 1ea38dc4643 ! 1: 122ff28ffbd git-p4: use raw string literals for regular expressions > @@ Metadata > ## Commit message ## > git-p4: use raw string literals for regular expressions > > - Fixes several Python diagnostics about invalid escape sequences. > + Fixes several Python diagnostics about invalid escape sequences. The > + diagnostics appear for me in Python 3.12, and may appear in earlier > + versions. The fix is to use raw string literals so that backslashes are > + not interpreted as introducing escape sequences. Raw string literals > + are already in use in this file, so adding more does not impact > + toolchain compatibility. > > Signed-off-by: James Touton > Thanks. Let's merge it down to 'next'.