From: Junio C Hamano <gitster@pobox.com>
To: Hugo Sales <hugo@hsal.es>
Cc: git@vger.kernel.org, Derrick Stolee <derrickstolee@github.com>,
Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
Subject: Re: [PATCH 0/3] Add `-p' option to `git-mv', inspired by `mkdir'
Date: Tue, 31 Oct 2023 13:30:14 +0900 [thread overview]
Message-ID: <xmqqlebj4dnt.fsf@gitster.g> (raw)
In-Reply-To: <1384513657.119681.1697027599941@office.mailbox.org> (Hugo Sales's message of "Wed, 11 Oct 2023 13:33:19 +0100 (WEST)")
Hugo Sales <hugo@hsal.es> writes:
>> Both are plausible, and "mkdir -p" does not have such a nasty
>> ambiguity. That is what makes me unsure about the new feature
>> (again, either with required "-p" or with implied "-p").
>
> I think the ambiguity is resolved by the inclusion of lack thereof
> of a trailing `/`.
The question is not if we can come up with a rule that the user can
use to disambiguate. It is if the user will find that such a rule
is a naturally acceptable way to disambiguate.
When both of
git mv file there/exists/such/a/directory
git mv file there/exists/such/a/directory/
create "there/exists/such/a/directory/file" and removes "file", with
or without a trailing slash, "you should add a slash if you want a
directory, and otherwise you should not add a slash" is a rather
arbitrary rule. Let's not go there. I still view the downside more
grave than having to occasionally do "mkdir".
next prev parent reply other threads:[~2023-10-31 4:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 23:34 [PATCH 0/3] Add `-p' option to `git-mv', inspired by `mkdir' Hugo Sales
2023-10-09 23:34 ` [PATCH 1/3] mv: Add -p option to create parent directories Hugo Sales
2023-10-09 23:34 ` [PATCH 2/3] mv: Add tests for new -p flag Hugo Sales
2023-10-09 23:34 ` [PATCH 3/3] mv: Add documentation for new `-p' flag Hugo Sales
2023-10-10 0:39 ` [PATCH 0/3] Add `-p' option to `git-mv', inspired by `mkdir' Junio C Hamano
2023-10-10 0:59 ` Junio C Hamano
2023-10-11 12:33 ` Hugo Sales
2023-10-31 4:30 ` Junio C Hamano [this message]
2023-10-31 4:54 ` Dragan Simic
2023-10-31 5:58 ` Junio C Hamano
2023-10-31 6:38 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlebj4dnt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=hugo@hsal.es \
--cc=shaoxuan.yuan02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).