From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 01660E7C4EB
	for <git@archiver.kernel.org>; Wed,  4 Oct 2023 18:29:08 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S244270AbjJDS3K (ORCPT <rfc822;git@archiver.kernel.org>);
        Wed, 4 Oct 2023 14:29:10 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40352 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S244279AbjJDS3J (ORCPT <rfc822;git@vger.kernel.org>);
        Wed, 4 Oct 2023 14:29:09 -0400
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 738A5BF
        for <git@vger.kernel.org>; Wed,  4 Oct 2023 11:29:05 -0700 (PDT)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id EA2091C0EAF;
        Wed,  4 Oct 2023 14:29:04 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:in-reply-to:references:date:message-id:mime-version
        :content-type; s=sasl; bh=GyG9YC4KrvFUb4k7gt71o+kjF4Jr2/+Q9YU3sv
        B0oGo=; b=QPQTq3Gz2QsdEDoSfhY2iXdUz40XtkfgnSh83e6XjGHv0g4YkEecdb
        d8zOHUs5DVNfZXJqbFklCQNrdK8kfNyWHFOawHGRx2varib3XGd7mOf12X4CeCNQ
        tPfNI43Xi8fi/wRkEk0Db4yD18FYUpyDk5Fx6kDoJ+ojNeg+B2Q1A=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id C88801C0EAE;
        Wed,  4 Oct 2023 14:29:04 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.125.165.85])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 2DCAB1C0EAD;
        Wed,  4 Oct 2023 14:29:04 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Jiang Xin <worldhello.net@gmail.com>
Cc:     Git List <git@vger.kernel.org>,
        Eric Sunshine <sunshine@sunshineco.com>,
        Jiang Xin <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH v3 2/4] transport-helper: call do_take_over() in
 process_connect
In-Reply-To: <e3dc18caa91bd16d95dc7c2bbd0e6eceedefe636.1696432594.git.zhiyou.jx@alibaba-inc.com>
        (Jiang Xin's message of "Wed, 4 Oct 2023 23:21:41 +0800")
References: <xmqqil7yq6ms.fsf@gitster.g>
        <cover.1696432593.git.zhiyou.jx@alibaba-inc.com>
        <e3dc18caa91bd16d95dc7c2bbd0e6eceedefe636.1696432594.git.zhiyou.jx@alibaba-inc.com>
Date:   Wed, 04 Oct 2023 11:29:02 -0700
Message-ID: <xmqqlecip7gx.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: E578A9B2-62E3-11EE-853D-25B3960A682E-77302942!pb-smtp2.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Jiang Xin <worldhello.net@gmail.com> writes:

> It is safe to make a refactor by moving the call of do_take_over()
> into the function process_connect().

"It is safe" only explains why it does not hurt, and does not
explain why it is a good idea to do so, though.