From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ilya Kantor" <iliakan@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <junio@pobox.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: CMakeLists.txt from contrib/buildsystems fails to build on Mac
Date: Wed, 08 Feb 2023 08:53:31 -0800 [thread overview]
Message-ID: <xmqqlel8t7xw.fsf@gitster.g> (raw)
In-Reply-To: <a120ea47-722d-2bb0-9c49-294a850af6af@dunelm.org.uk> (Phillip Wood's message of "Wed, 8 Feb 2023 14:31:58 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> On 08/02/2023 11:57, Ævar Arnfjörð Bjarmason wrote:
>> Or rather, that GFW would be fixing it up, but then I don't see why it
>> should be in git.git, which as your message shows just leads to
>> confusion about why this component is in git.git's tree.
>
> I think Ilya's message shows we need to update the instructions in
> CMakeLists.txt to make it clear it is Windows only.
That matches the conclusion in the thread
https://lore.kernel.org/git/1e701a54-0356-9f55-ab53-9d8bfdd93e55@dunelm.org.uk/
which was a subthread of the primary discussion we had on this
topic, which starts here:
https://lore.kernel.org/git/544fff8a-7d56-57a1-00a3-d1a9302e227c@dunelm.org.uk/
I am fine with either marking CMakeLists as windows-only, or
removing it from my tree and have GfW folks add it back to their
tree.
Or keep it in my tree, make CI failures around it "soft" failures,
and mark it prominently as "work in progress" on platforms other
than Windows. But this choice is only valid if we as the project
want to expend more effort on enhancing and extending cmake support.
I personally do not believe in having to maintain two parallel build
systems for non Windows and keep them in sync.
prev parent reply other threads:[~2023-02-08 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 11:45 CMakeLists.txt from contrib/buildsystems fails to build on Mac Ilya Kantor
2023-02-08 11:57 ` Ævar Arnfjörð Bjarmason
2023-02-08 14:31 ` Phillip Wood
2023-02-08 14:34 ` Ilya Kantor
2023-02-08 16:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlel8t7xw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=iliakan@gmail.com \
--cc=junio@pobox.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).