From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DC8ABC43334
	for <git@archiver.kernel.org>; Mon, 25 Jul 2022 19:01:12 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236078AbiGYTBL (ORCPT <rfc822;git@archiver.kernel.org>);
        Mon, 25 Jul 2022 15:01:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33250 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229544AbiGYTBK (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 25 Jul 2022 15:01:10 -0400
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADBDDB484
        for <git@vger.kernel.org>; Mon, 25 Jul 2022 12:01:09 -0700 (PDT)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id EC79E140A12;
        Mon, 25 Jul 2022 15:01:08 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type:content-transfer-encoding; s=sasl; bh=mN/kTzmLOGhE
        w8terb4IrT0dKTe2CK+KtDsarQoaBC0=; b=JUB+p2B4JNRXvYWszjddBq+hiQSL
        eU90Gyh88rDKqSxj9/QjsYZoeZmg/SN3JcAGfOY3T7ZbfGWmD6IhfvQFsCbQ0S+y
        LDhE/Gc9CtVLbzeHCHkXamYLN81wgjMh+ZZV0dF5dooHUoSxM/e1CI8eihGaFkw8
        EsQEiNoHilx+isk=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 716ED140A11;
        Mon, 25 Jul 2022 15:01:08 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.105.40.190])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 45D7E140A10;
        Mon, 25 Jul 2022 15:01:07 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason <avarab@gmail.com>
Cc:     git@vger.kernel.org
Subject: Re: [PATCH] string_list: use the right kind of STRING_LIST_INIT
References: <xmqq7d471dns.fsf@gitster.g>
        <220721.868ronuhrm.gmgdl@evledraar.gmail.com>
Date:   Mon, 25 Jul 2022 12:01:05 -0700
In-Reply-To: <220721.868ronuhrm.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?=
 =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?=
        Bjarmason"'s message of "Thu, 21 Jul 2022 07:55:49 +0200")
Message-ID: <xmqqlesh3tla.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
X-Pobox-Relay-ID: 239F4A1A-0C4C-11ED-A385-CB998F0A682E-77302942!pb-smtp2.pobox.com
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

=C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason <avarab@gmail.com> writes:

> Heh :) I think it's safe to give this my Reviewed-By, since I've been
> running with this patch for almost a year now:
> https://github.com/avar/git/commit/bdf4466eb92
>
> It's on a branch of some WIP string_list API fixes that I haven't sent
> in, but the fix looks good to me...

I do not think it is all that urgent, but I do not think it is worth
wasting our braincells to remember that a WIP series is waiting to
touch and update this area again, so I'll merge this single patch
down to 'next' and 'master' soonish.

Thanks.