From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Carlo Arenas <carenas@gmail.com>,
Phillip Wood <phillip.wood@talktalk.net>
Subject: Re: [PATCH v2] CI: select CC based on CC_PACKAGE (again)
Date: Thu, 21 Apr 2022 12:51:07 -0700 [thread overview]
Message-ID: <xmqqlevygqqc.fsf@gitster.g> (raw)
In-Reply-To: <220421.867d7i6ycr.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 21 Apr 2022 21:13:57 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> I'm happy to rephrase it however you'd like, but I'm a bit confused by
> the "saw any mention in the proposed log message". I'm fairly sure
> paragraph 2 onwards covers this, i.e. how linux-gcc's behavior is
> changed (as it also regressed).
Yeah, true, """Likewise for the linux-gcc job CC=gcc-8 was changed
to the implicit CC=gcc, which would select GCC 9.4.0 instead of GCC
8.4.0.""" that you wrote is exactly about it.
I was confused because immediately after that you said it was not a
bug, so I dismissed it as not part or the real issue. Perhaps
striking that "not a bug" part may make it less confusing? I dunno.
> What I suppose is left undiscussed is that jobs that don't define
> CC_PACKAGE at all won't be impacted, is that what you wanted to be
> explicitly mentioned?
Yes, I agree that is a good idea, too. Or you can steal the "before
and after" table I gave you in the message you are responding to, if
you think it helps.
Thanks.
next prev parent reply other threads:[~2022-04-21 19:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 13:03 [PATCH] CI: select CC based on CC_PACKAGE (again) Ævar Arnfjörð Bjarmason
2022-04-21 16:26 ` Phillip Wood
2022-04-21 17:48 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-04-21 19:05 ` Carlo Arenas
2022-04-21 19:11 ` Junio C Hamano
2022-04-21 19:22 ` Carlo Arenas
2022-04-21 19:47 ` Junio C Hamano
2022-04-21 19:08 ` Junio C Hamano
2022-04-21 19:13 ` Ævar Arnfjörð Bjarmason
2022-04-21 19:51 ` Junio C Hamano [this message]
2022-04-21 19:52 ` Ævar Arnfjörð Bjarmason
2022-04-21 19:55 ` Junio C Hamano
2022-04-22 9:20 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
2022-04-22 9:25 ` Phillip Wood
2022-04-22 11:43 ` Ævar Arnfjörð Bjarmason
2022-04-22 18:27 ` Junio C Hamano
2022-04-22 22:40 ` Junio C Hamano
2022-04-22 22:46 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlevygqqc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@talktalk.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).