git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>, Stephen Manz <smanz@alum.mit.edu>
Subject: Re: What's cooking in git.git (Jul 2021, #03; Tue, 13)
Date: Wed, 14 Jul 2021 09:30:16 -0700	[thread overview]
Message-ID: <xmqqlf68yi1z.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQfsACHAQhCrXDs==18p1Ds8MtMRZDmSfso9HsO6dF-qg@mail.gmail.com> (Eric Sunshine's message of "Tue, 13 Jul 2021 22:16:54 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Tue, Jul 13, 2021 at 9:07 PM Junio C Hamano <gitster@pobox.com> wrote:
>> * sm/worktree-add-lock (2021-07-12) 3 commits
>>  - worktree: teach `add` to accept --reason <string> with --lock
>>  - worktree: mark lock strings with `_()` for translation
>>  - t2400: clean up '"add" worktree with lock' test
>>
>>  "git worktree add --lock" learned to record why the worktree is
>>  locked with a custom message.
>>
>>  Ready?
>
> I think this series is ready and gave my Reviewed-by: here[1]. One of
> the new tests contains an unnecessary but harmless `test -f`[2], but
> it's such a minor nit that I doubt it's worth demanding a re-roll.

I think having "test -f" is the right thing to do, so [2] is
probably OK as-is.  test_cmp may want to complain about a possible
bug in the test when given a missing file.  I do agree with you that
the unquoted "why not" is a bit problematic from the readability's
point of view but I agree it is not too huge a deal.

Let me "rebase -i"-in your Reviewed-by: before merging it down to
'next'.

Thanks.


> [1]: https://lore.kernel.org/git/CAPig+cSVsJ9AtAMqtRQpyuosCDCGi+mu2C1PJUK49WTb5KvcWQ@mail.gmail.com/
> [2]: https://lore.kernel.org/git/CAPig+cQVSUg1aqry_hMydJ=Uo=-VhOog6TUTpG=0on0LUcw8Dg@mail.gmail.com/

  reply	other threads:[~2021-07-14 16:30 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  1:07 What's cooking in git.git (Jul 2021, #03; Tue, 13) Junio C Hamano
2021-07-14  2:16 ` Eric Sunshine
2021-07-14 16:30   ` Junio C Hamano [this message]
2021-07-14 22:39     ` Eric Sunshine
2021-07-14 22:44       ` Junio C Hamano
2021-07-14  8:42 ` Han-Wen Nienhuys
2021-07-14 11:53   ` Ævar Arnfjörð Bjarmason
2021-07-14 11:54   ` Ævar Arnfjörð Bjarmason
2021-07-14 17:28   ` Junio C Hamano
2021-07-14 13:11 ` Derrick Stolee
2021-07-14 14:32   ` Ævar Arnfjörð Bjarmason
2021-07-15 16:25     ` [PATCH] CodingGuidelines: recommend gender-neutral description Junio C Hamano
2021-07-15 16:35       ` Eric Sunshine
2021-07-15 16:47         ` Taylor Blau
2021-07-15 18:02           ` Junio C Hamano
2021-07-16 21:25           ` Felipe Contreras
2021-07-15 17:27         ` Derrick Stolee
2021-07-16 15:11           ` Johannes Schindelin
2021-07-16 21:22           ` Felipe Contreras
2021-07-16 18:41       ` [PATCH v2] " Junio C Hamano
2021-07-16 19:05         ` Derrick Stolee
2021-07-16 19:11         ` Ævar Arnfjörð Bjarmason
2021-07-16 19:50           ` Junio C Hamano
2021-07-16 21:14             ` Felipe Contreras
2021-08-12  8:35       ` [PATCH] " Bagas Sanjaya
2021-07-14 20:11 ` What's cooking in git.git (Jul 2021, #03; Tue, 13) Taylor Blau
2021-07-19  7:35 ` Patrick Steinhardt
2021-07-19  7:53   ` Felipe Contreras
2021-07-19  8:35     ` Jeff King
2021-07-19 10:42       ` Felipe Contreras
2021-07-19 10:56         ` Patrick Steinhardt
2021-07-19 11:25           ` Felipe Contreras
2021-07-19  8:33   ` Jeff King
2021-07-19 10:41     ` Patrick Steinhardt
2021-07-19 10:52       ` Jeff King
2021-07-19 18:40       ` Junio C Hamano
2021-07-19 19:57         ` Felipe Contreras
2021-07-20  6:31           ` Patrick Steinhardt
2021-07-20  7:21             ` Felipe Contreras
2021-07-20  6:32           ` [PATCH] t0000: fix test if run with TEST_OUTPUT_DIRECTORY Patrick Steinhardt
2021-07-20  7:11             ` Jeff King
2021-07-20 16:21               ` Junio C Hamano
2021-07-20  7:24             ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlf68yi1z.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=smanz@alum.mit.edu \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).