From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Jacob Vosmaer <jacob@gitlab.com>,
peff@peff.net, git@vger.kernel.org, jeffhost@microsoft.com,
jonathantanmy@google.com
Subject: Re: [PATCH v3 1/1] upload-pack.c: fix filter spec quoting bug
Date: Tue, 26 Jan 2021 09:51:35 -0800 [thread overview]
Message-ID: <xmqqlfcf37tk.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <874kj46mwf.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 26 Jan 2021 10:57:36 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Tue, Jan 26 2021, Jacob Vosmaer wrote:
>
>> This fixes a bug that occurs when you combine partial clone and
>> uploadpack.packobjectshook. You can reproduce it as follows:
>
> Let's:
>
> * Refer to the commit we're fixing a bug in, i.e. Junio's mention of
> 10ac85c7 (upload-pack: add object filtering for partial clone,
> 2017-12-08) upthread.
>
> * See also "imperative-mood" in SubmittingPatches. I.e. say "Fix a bug
> in ..." not "This fixes ... can be reproduced as"
>
> * uploadpack.packObjectsHook not uploadpack.packobjectshook except in C
> code.
>
> ... [jc: all the helpful hints snipped] ...
>
> Thanks for hacking this up! Hopefully the above is helpful and not too
> nitpicky. Mainly wanted to help you get future patches through more
> easily...
Yeah, thanks, both, for aiming higher ;-)
I have to admit that I did find the log message a bit lacking, and
that was why I had to dig bit to find out how the historical issue
happened myself in the first place, and I tend to agree that it
feels a bit of waste for that work to end up buried in the list
archive without getting reflected in the proposed log message.
next prev parent reply other threads:[~2021-01-26 22:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 14:21 [PATCH 0/1] upload-pack.c: fix filter spec quoting bug Jacob Vosmaer
2021-01-22 14:21 ` [PATCH 1/1] " Jacob Vosmaer
2021-01-22 20:32 ` Jeff King
2021-01-22 21:03 ` [PATCH] run-command: document use_shell option Jeff King
2021-01-22 21:32 ` Taylor Blau
2021-01-22 22:21 ` Junio C Hamano
2021-01-23 0:04 ` Jeff King
2021-01-22 22:10 ` [PATCH 1/1] upload-pack.c: fix filter spec quoting bug Junio C Hamano
2021-01-25 17:09 ` [PATCH v2] " Jacob Vosmaer
2021-01-25 19:48 ` Junio C Hamano
2021-01-25 21:16 ` Jeff King
2021-01-25 23:09 ` [PATCH v3 0/1] " Jacob Vosmaer
2021-01-25 23:09 ` [PATCH v3 1/1] " Jacob Vosmaer
2021-01-26 9:57 ` Ævar Arnfjörð Bjarmason
2021-01-26 10:29 ` Jacob Vosmaer
2021-01-26 17:46 ` Junio C Hamano
2021-01-26 21:09 ` Jeff King
2021-01-28 16:04 ` [PATCH v4] " Jacob Vosmaer
[not found] ` <xmqqmtwsx4d9.fsf@gitster.c.googlers.com>
2021-01-28 21:12 ` Jacob Vosmaer
2021-01-28 21:40 ` Jacob Vosmaer
2021-01-28 21:51 ` Jeff King
2021-02-01 20:31 ` Jacob Vosmaer
2021-01-28 21:58 ` Junio C Hamano
2021-02-01 20:29 ` [PATCH v5 0/1] " Jacob Vosmaer
2021-02-01 20:29 ` [PATCH v5 1/1] " Jacob Vosmaer
2021-02-02 5:49 ` [PATCH v5 0/1] " Junio C Hamano
2021-02-02 10:37 ` [PATCH 1/1] t5544: clarify 'hook works with partial clone' test Jacob Vosmaer
2021-02-02 17:22 ` Eric Sunshine
2021-02-02 19:24 ` [PATCH v2] " Jacob Vosmaer
2021-02-02 20:21 ` Junio C Hamano
2021-01-26 17:51 ` Junio C Hamano [this message]
2021-01-26 21:07 ` [PATCH v3 1/1] upload-pack.c: fix filter spec quoting bug Jeff King
2021-01-26 0:01 ` [PATCH v3 0/1] " Junio C Hamano
2021-01-26 2:25 ` [PATCH v2] " Junio C Hamano
2021-01-25 21:16 ` Jeff King
2021-01-25 17:14 ` [PATCH 1/1] " Jacob Vosmaer
2021-01-25 17:41 ` Jacob Vosmaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfcf37tk.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob@gitlab.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).