git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Antonio Russo <aerusso@aerusso.net>
Cc: Abhishek Kumar <abhishekkumar8222@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] t6016: move to lib-log-graph.sh framework
Date: Wed, 06 Jan 2021 12:55:21 -0800	[thread overview]
Message-ID: <xmqqlfd5rdja.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <d01e2830-d579-67c6-1076-ed44cff27ad7@aerusso.net> (Antonio Russo's message of "Wed, 6 Jan 2021 08:21:01 -0700")

Antonio Russo <aerusso@aerusso.net> writes:

> You are correct that the A4 and A6 tags can be removed without affecting
> the output.  In fact, A4 is basically immediately deleted (in the second test).
> I can remove that, if we want to stop testing the tag deletion logic here.
> I suppose that is sufficiently validated elsewhere in the test suite.
>
> There's a (weak IMO) argument to keep the A6 tag, since ...

I see.  Thanks for explaining.

> My guiding principle when I made this patch was to be as minimally invasive
> as possible, while allowing modifications to this file to be pleasant---which
> I must admit is my ulterior motive.
>
> I can certainly remove these "extraneous" tags if desired.

I actually am _for_ keeping these tags.  It is just that I want to
see the reason why these tags, some of which are no longer needed
for the purpose of matching the output with expectation, are kept
explained in the proposed log message.

Thanks.

  reply	other threads:[~2021-01-06 20:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04  2:30 [PATCH] t6016: move to lib-log-graph.sh framework Antonio Russo
2021-01-04  6:26 ` Abhishek Kumar
2021-01-05  0:59   ` Antonio Russo
2021-01-06  5:05   ` Junio C Hamano
2021-01-06 15:21     ` Antonio Russo
2021-01-06 20:55       ` Junio C Hamano [this message]
2021-01-10 15:28 ` [PATCH v2] " Antonio Russo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlfd5rdja.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=abhishekkumar8222@gmail.com \
    --cc=aerusso@aerusso.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).