From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Brandon Williams <bwilliams.eng@gmail.com>,
Jacob Keller <jacob.keller@gmail.com>,
Tomo Krajina <tkrajina@gmail.com>
Subject: Re: [PATCH v2] refspec: make @ a synonym of HEAD
Date: Wed, 25 Nov 2020 16:01:23 -0800 [thread overview]
Message-ID: <xmqqlfepasvg.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAMP44s2cpPgg55XHTr=cRqRcrMOkU=qcrM=RpWYwVJJdd9V4JA@mail.gmail.com> (Felipe Contreras's message of "Wed, 25 Nov 2020 17:48:29 -0600")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Tue, Nov 24, 2020 at 7:53 PM Junio C Hamano <gitster@pobox.com> wrote:
>> ...
>> we care about both of these forms working, not just the singleton
>> form, so it is not just "not hurt", but is actively a good thing, to
>> protect both forms from future breakage. After all, that is why we
>> have tests.
>
> Both forms were already tested.
Yeah, I did realize it in my review of reviews I do after sending
all the messages yesterday (not just on this topic), so there is no
strong reason to duplicate all the tests that involve HEAD.
Thanks for pushing back on this point.
prev parent reply other threads:[~2020-11-26 0:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 0:11 [PATCH v2] refspec: make @ a synonym of HEAD Felipe Contreras
2020-11-25 0:36 ` Junio C Hamano
2020-11-25 0:43 ` Felipe Contreras
2020-11-25 1:53 ` Junio C Hamano
2020-11-25 23:48 ` Felipe Contreras
2020-11-26 0:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfepasvg.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=bwilliams.eng@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
--cc=tkrajina@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).