git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, sluongng@gmail.com,
	Derrick Stolee <derrickstolee@github.com>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] multi-pack-index: repack batches below --batch-size
Date: Tue, 11 Aug 2020 14:06:07 -0700	[thread overview]
Message-ID: <xmqqlfik99kw.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200811155013.GF19871@syl.lan> (Taylor Blau's message of "Tue, 11 Aug 2020 11:50:13 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> OK. This '--batch-size' parameter is a little magical to me, but the
> behavior you are describing seems sane. I think that your assessment of
> the down-side is reasonable, too.
>
> Looks fine to me.
>
>   Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
>> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>

Thanks, both.

      reply	other threads:[~2020-08-11 21:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 15:30 [PATCH] multi-pack-index: repack batches below --batch-size Derrick Stolee via GitGitGadget
2020-08-11 15:50 ` Taylor Blau
2020-08-11 21:06   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlfik99kw.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=derrickstolee@github.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=sluongng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).